Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding system tests for HappyBase Table.cells() and scan(). #1606

Merged
merged 1 commit into from
Mar 14, 2016
Merged

Adding system tests for HappyBase Table.cells() and scan(). #1606

merged 1 commit into from
Mar 14, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Mar 14, 2016

No description provided.

@dhermes dhermes added the api: bigtable Issues related to the Bigtable API. label Mar 14, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 14, 2016
tseaver
tseaver reviewed Mar 14, 2016
View reviewed changes
system_tests/bigtable_happybase.py

# Scan with a row prefix.
prefix = ROW_KEY2[:-1]
self.assertEqual(prefix, ROW_KEY3[:-1])

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor

tseaver commented Mar 14, 2016

LGTM except for the extraneous assertions, which made me wonder if I were misreading something.

@dhermes
Copy link
Contributor Author

dhermes commented Mar 14, 2016

LMK what you think of my comments. I'd like to get this merged and wrap up the Happybase system tests (AFAIK only one PR left for those targeting Cloud Bigtable backend).

@tseaver
Copy link
Contributor

tseaver commented Mar 14, 2016

You can merge as it stands, but maybe follow up with an explanation of why you think those assertions might fail.

@dhermes
Copy link
Contributor Author

dhermes commented Mar 14, 2016

I don't think they'll fail. The assertions are there as a sanity check, i.e. we meant this to be true with the literals we created, but we want to make extra double sure.

dhermes added a commit that referenced this pull request Mar 14, 2016
@dhermes
Merge pull request #1606 from dhermes/sys-test-happybase-scan
170767c 
Adding system tests for HappyBase Table.cells() and scan().
@dhermes dhermes merged commit 170767c into googleapis:master Mar 14, 2016
@dhermes dhermes deleted the sys-test-happybase-scan branch March 14, 2016 20:40
@dhermes dhermes mentioned this pull request Apr 1, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tseaver tseaver

Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhermes @tseaver @googlebot