PEP257 Clean-up of docstrings. #1996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| @@ -439,8 +441,7 @@ def _to_bytes(value, encoding='ascii'): | |||
| :rtype: str / bytes | |||
| :returns: The original value converted to bytes (if unicode) or as passed | |||
| in if it started out as bytes. | |||
| :raises: :class:`TypeError <exceptions.TypeError>` if the value | |||
| could not be converted to bytes. | |||
| :raises TypeError: if the value could not be converted to bytes. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Fixes all Pylint failures of - missing-returns-doc - redundant-returns-doc - ungrouped-imports Also makes a little headway on missing-raises-doc though it's unclear if this error should be fixed. Towards googleapis#1968.
This is because the false positive was fixed in Pylint 1.6.4.
dhermes
force-pushed
the
partial-revert-1974
branch
from
a76c130
to
8ee5e03
Compare
|
@tseaver FYI I added another commit since |
|
@tseaver Issues remaining? |
|
LGTM |
This was referenced Aug 3, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes all Pylint failures of
missing-returns-docredundant-returns-docungrouped-importsAlso makes a little headway on
missing-raises-docthough it's unclear if this error should be fixed. Also pylint-dev/pylint@8d35557 makes the badcatching-non-exceptiongo away.Towards #1968.