Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The link to the API documentation has changed. #2069

Closed
wants to merge 1 commit into from
Closed

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Aug 9, 2016

The /stable path for the docs is still showing the docs for v0.17.0, not v0.18.0.

I notice that there are no previous versions selectable, though maybe that'll change with new releases?

The `/stable` path for the docs is still showing the docs for v0.17.0, not v0.18.0.

I notice that there are no previous versions selectable, though maybe that'll change with new releases?
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 9, 2016
@tswast tswast added the docs label Aug 9, 2016
@dhermes
Copy link
Contributor

dhermes commented Aug 9, 2016

Thanks @tswast. I want to make sure we get @daspecster in the loop on this, but he is out-of-country right now. Change content looks good (LGTM), I suppose we should merge and create an issue assigned to @daspecster?

@tswast
Copy link
Contributor Author

tswast commented Aug 9, 2016

Yeah, I'm wondering if we should wait to update this link. I'm not very happy with the state of the docs for 0.18.x. Besides not having links to previous versions #2073 , they are missing info #2072 and have broken links #2061

@dhermes
Copy link
Contributor

dhermes commented Aug 9, 2016

It's not really 0.18.x, it's the move to using the docs template in gcloud-common (but they do coincide)

@daspecster
Copy link
Contributor

@tswast @dhermes yeah I would like to get things cleaned up first if possible.

@tseaver
Copy link
Contributor

tseaver commented Aug 17, 2016

@tswast for future reference, the workflow we prefer has contributors (including us!) pushing changes to personal forks and then creating PRs from them. In your case, for instance, the push to a new branch triggered CI checks that normally occur only after merging the reviewed PR.

I've restarted the PR build to see if it can pass now that the missing GAX release issue is fixed.

@dhermes
Copy link
Contributor

dhermes commented Aug 17, 2016

@tseaver AFAICT all these extra checks come in when the PR is created via the GitHub UI.

@tseaver
Copy link
Contributor

tseaver commented Aug 17, 2016

@dhermes they come into play whenever a branch is pushed to this repository: it is possible for contributors to do that when editing through the UI, but they also have an option to put the changes in their own fork. I don't recall what the default for that choice is.

@tswast
Copy link
Contributor Author

tswast commented Aug 17, 2016

GitHub doesn't even give me the option to write the commit from the UI to my fork.

image

I guess the workflow has to be to fork, then edit in my fork and send PR from there, but that adds a lot of friction. :-(

@dhermes
Copy link
Contributor

dhermes commented Aug 17, 2016

Ah, I see now. Silly GitHub

@daspecster
Copy link
Contributor

@tswast but if you fork the repo you get a tshirt and stickers and stuff! jk...

So we merged a bunch of fixes for the issues I mentioned earlier.
There's still #2039 and I need to get autogeneration of the tags working. I should have it by tomorrow morning.

@dhermes
Copy link
Contributor

dhermes commented Aug 19, 2016

Replaced by #2147, deleting the branch

@dhermes dhermes closed this Aug 19, 2016
@dhermes dhermes deleted the tswast-newdocs branch August 19, 2016 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants