-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The link to the API documentation has changed. #2069
Conversation
The `/stable` path for the docs is still showing the docs for v0.17.0, not v0.18.0. I notice that there are no previous versions selectable, though maybe that'll change with new releases?
Thanks @tswast. I want to make sure we get @daspecster in the loop on this, but he is out-of-country right now. Change content looks good (LGTM), I suppose we should merge and create an issue assigned to @daspecster? |
It's not really 0.18.x, it's the move to using the docs template in |
@tswast for future reference, the workflow we prefer has contributors (including us!) pushing changes to personal forks and then creating PRs from them. In your case, for instance, the push to a new branch triggered CI checks that normally occur only after merging the reviewed PR. I've restarted the PR build to see if it can pass now that the missing GAX release issue is fixed. |
@tseaver AFAICT all these extra checks come in when the PR is created via the GitHub UI. |
@dhermes they come into play whenever a branch is pushed to this repository: it is possible for contributors to do that when editing through the UI, but they also have an option to put the changes in their own fork. I don't recall what the default for that choice is. |
Ah, I see now. Silly GitHub |
Replaced by #2147, deleting the branch |
The
/stable
path for the docs is still showing the docs for v0.17.0, not v0.18.0.I notice that there are no previous versions selectable, though maybe that'll change with new releases?