Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitoring: Minor Style Fixups #2355

Merged
merged 1 commit into from
Sep 20, 2016
Merged

Monitoring: Minor Style Fixups #2355

merged 1 commit into from
Sep 20, 2016

Conversation

waprin
Copy link
Contributor

@waprin waprin commented Sep 19, 2016

From dhermes review comments:

  1. Two spaces before hash in line comments
  2. Single quotes
  3. Trailing commas in mult-line dicts

Monitoring: Minor Style Fixups
e6a0667 
From dhermes review comments
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 19, 2016
dhermes
dhermes approved these changes Sep 19, 2016
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tseaver tseaver added the api: monitoring Issues related to the Cloud Monitoring API. label Sep 20, 2016
@tseaver tseaver merged commit 75835c8 into googleapis:master Sep 20, 2016
@dhermes
Copy link
Contributor

dhermes commented Sep 20, 2016

@waprin forgot you didn't have merge privileges. My bad

@dhermes dhermes mentioned this pull request Sep 29, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes approved these changes

Assignees
No one assigned
Labels
api: monitoring Issues related to the Cloud Monitoring API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@waprin @dhermes @tseaver @googlebot