Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove orphaned _fixtures.py. #2362

Merged
merged 2 commits into from
Sep 20, 2016
Merged

Remove orphaned _fixtures.py. #2362

merged 2 commits into from
Sep 20, 2016

Conversation

daspecster
Copy link
Contributor

@dhermes, sorry I missed this. It slipped by me in one of the PRs when I was rebasing from the rename/moving tests.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 20, 2016
@daspecster daspecster mentioned this pull request Sep 20, 2016
Closed
@tseaver
Copy link
Contributor

tseaver commented Sep 20, 2016

LGTM

@dhermes
Copy link
Contributor

dhermes commented Sep 20, 2016

May also want to remove it from run_pylint:
https://github.com/GoogleCloudPlatform/google-cloud-python/blob/d3e28ce8ae5bee1a637a11d11227d294cfa8302c/scripts/run_pylint.py#L41

@daspecster
Copy link
Contributor Author

@dhermes, I just removed reference in run_pylint.py.

@dhermes
Copy link
Contributor

dhermes commented Sep 20, 2016

LGTM to merge

@daspecster daspecster merged commit 707ee67 into googleapis:master Sep 20, 2016
@daspecster daspecster deleted the remove-misplaced-vision-fixtures branch September 20, 2016 15:44
@dhermes dhermes mentioned this pull request Sep 29, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daspecster @tseaver @dhermes @googlebot