HYGIENE: Using assertIsInstance, assertIs, assertIsNone, assertIsNotNone when relevant #2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Did this using: https://gist.github.com/dhermes/57e29d96b17a4e1543b47bd2fcebfc07 NOTE: Some usage that span multiple lines are still not changed.
Done manually by checking the output of: $ git grep ' is$' -- unit_tests/ $ git grep ' is$' -- system_tests/ $ git grep ' is ' -- unit_tests/ $ git grep ' is ' -- system_tests/
Did this using: https://gist.github.com/dhermes/f4176452c2436b14e0c97a114d98bace Also had to manually undo a few of the changes since the regex matched things like self.assertEqual(foo, [(value, has_some, parens, None)])
googlebot
added
the
cla: yes
|
LGTM pending Travis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by:
https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2348/files#r79664980
Note that virtually all of these commits were created by REGEX matching / replacing scripts, so it's worth just reviewing those scripts:
I ran the unit and system tests locally to make sure they all still pass.