Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making license headers in Python files more uniform #2370

Merged
merged 2 commits into from
Sep 22, 2016
Merged

Making license headers in Python files more uniform #2370

merged 2 commits into from
Sep 22, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Sep 20, 2016

  1. Originally started as a check for which files didn't have license headers (due to Moving core into designated package. #2367 (comment))
  2. Used a script to verify: https://gist.github.com/dhermes/17177b603e2b22902334947d9871529c
  3. Maybe we should incorporate the script into our build rule to prevent files checked in with bad or missing license headers?
  4. Should the script be extended to incorporate more than just Python files?

@dhermes
Making 2016 license headers uniform.
8c9c9d3 
Done via:

$ git grep -l '# Copyright 2016 Google Inc. All Rights Reserved.' | \
> xargs sed -i 's/All Rights Reserved/All rights reserved/g'
@dhermes
Making all license headers uniform.
d286a6b 
Also adding license headers where they are missing.

Also had to tweak the max lines allowed in a test module
due to added license header.

Used: https://gist.github.com/dhermes/17177b603e2b22902334947d9871529c
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 20, 2016
@dhermes dhermes mentioned this pull request Sep 20, 2016
Merged
@daspecster daspecster mentioned this pull request Sep 21, 2016
Closed
@daspecster
Copy link
Contributor

I'm 👍 for point number 3. I added #2371 to discuss.
I think for number 4, that might be up to legal?

These updates LGTM.

@dhermes dhermes mentioned this pull request Sep 22, 2016
Closed
@dhermes dhermes merged commit 99ac955 into googleapis:master Sep 22, 2016
@dhermes dhermes deleted the license-header-check branch September 22, 2016 18:12
This was referenced Sep 23, 2016
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daspecster daspecster daspecster approved these changes

Assignees

@tseaver tseaver

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhermes @daspecster @tseaver @googlebot