Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise exception if retry-backoff fails to pass predicate. #2380

Merged
merged 2 commits into from
Sep 21, 2016
Merged

Raise exception if retry-backoff fails to pass predicate. #2380

merged 2 commits into from
Sep 21, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 21, 2016

Closes #2315.

Updates coming to remove redundant tests of assertions after retry.

@tseaver tseaver added testing do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Sep 21, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 21, 2016
@dhermes
Copy link
Contributor

dhermes commented Sep 21, 2016

LGTM pending Travis

@tseaver
Copy link
Contributor Author

tseaver commented Sep 21, 2016

@dhermes Follow-on commit pending to clean out redundant assertions (I just need to let the system tests pass locally one more time).

@tseaver tseaver removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 21, 2016
@dhermes
Copy link
Contributor

dhermes commented Sep 21, 2016

Thanks for the residual clean up! Still LGTM

@tseaver tseaver merged commit 0c4fca3 into googleapis:master Sep 21, 2016
@tseaver tseaver deleted the 2315-retry_instance_state-retry_result-raise branch September 21, 2016 20:39
@dhermes dhermes mentioned this pull request Sep 29, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @dhermes @daspecster @googlebot