Update PyLint config for latest version. #2396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Done via: $ pylint --version No config file found, using default configuration pylint 1.6.4, astroid 1.4.8 Python 2.7.12 (default, Jul 17 2016, 01:21:14) [GCC 4.8.4] $ pylint --generate-rcfile > scripts/pylintrc_v1.6.4_default
This is to make it easier to move defaults over to the newly generated file.
This is the final section, hence the original config has also been deleted.
googlebot
added
the
cla: yes
daspecster
reviewed
Sep 23, 2016
| # | ||
| [MASTER] | ||
|
|
||
| # Specify a configuration file. | ||
| # DEFAULT: rcfile= | ||
| #rcfile= |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| round-builtin, | ||
| hex-method, | ||
| nonzero-method, | ||
| map-builtin-not-iterating, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -232,146 +260,218 @@ good-names = i, j, k, ex, Run, _, | |||
| id, | |||
|
|
|||
| # Bad variable names which should always be refused, separated by a comma | |||
| # DEFAULT: bad-names=foo,bar,baz,toto,tutu,tata | |||
| bad-names=foo,bar,baz,toto,tutu,tata | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1256.
This PR diff will probably just look like a giant splat. I went through this process with tiny commits to make the review easier. I started with the default config side-by-side with ours. Then I narrowed down ours to only edited values. Then I moved over those edited values a few at a time.
Worth noting: My main goal was to be able to increase
jobs=1after this PR is merged, to speed up PyLint.