Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #223: marshal list values from protobufs #246

Merged
merged 4 commits into from
Oct 16, 2014
Merged

Fix #223: marshal list values from protobufs #246

merged 4 commits into from
Oct 16, 2014

Commits on Oct 16, 2014

  1. Rename helper memor to indicate usage. 

    Expected argument is a Property protobuf.
    @tseaver
    tseaver committed Oct 16, 2014
    Configuration menu
    Copy the full SHA
    8bf8bad View commit details
    Browse the repository at this point in the history

  2. Factor out value_pb bits from '_get_value_from_property_pb'.

    @tseaver
    tseaver committed Oct 16, 2014
    Configuration menu
    Copy the full SHA
    0a2cd13 View commit details
    Browse the repository at this point in the history

  3. Add support for 'list_value' field of a Value protobuf. 

    Fixes #223.

Manually lands Tagtoo/gcloud-python@0475d5e, included by mistake in PR #126.
    @tseaver
    tseaver committed Oct 16, 2014
    Configuration menu
    Copy the full SHA
    61e3c2c View commit details
    Browse the repository at this point in the history

  4. Kowtow to pylint's over-fussy 'too-many-return-statements'. 

    Incorporates feedback from @dhermes.
    @tseaver
    tseaver committed Oct 16, 2014
    Configuration menu
    Copy the full SHA
    fc4353f View commit details
    Browse the repository at this point in the history