-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making max_results part of the base Iterator class. #2490
Conversation
except StopIteration: | ||
item = self._update_items() | ||
self.num_results += 1 | ||
return item |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
I'm very open to suggestions on other unit / system tests I could add to this PR. Just wanted to get it out there for discussion's sake. |
In the process, also making sure to lower maxResults on subsequent requests. Fixes googleapis#1467.
I would've thought changing to use |
Making max_results part of the base Iterator class.
In the process, also making sure to lower
maxResults
on subsequent requests.Fixes #1467.