Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates from #2344 for speech API. #2495

Merged
merged 4 commits into from
Oct 6, 2016
Merged

Updates from #2344 for speech API. #2495

merged 4 commits into from
Oct 6, 2016

Conversation

daspecster
Copy link
Contributor

See: #2344 (comment)

  • Update async_recognize() and sync_recognize() method signatures and examples.
  • Add more examples showing usage of other options.

@daspecster daspecster added the api: speech Issues related to the Speech-to-Text API. label Oct 4, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 4, 2016
dhermes
dhermes reviewed Oct 4, 2016
View reviewed changes
docs/speech-usage.rst
@@ -67,11 +67,14 @@ Synchronous Recognition
The :meth:`~google.cloud.speech.Client.sync_recognize` method converts speech
data to text and returns alternative text transcriptons.

This example uses ``language_code='en-GB'`` to better recognize a dialect from

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes
dhermes suggested changes Oct 4, 2016
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good. Assuming tests are green, these changes should be easy to make / uncontroversial.

docs/speech-usage.rst
... None, 'gs://my-bucket/recording.flac',
... 'FLAC', 16000, max_alternatives=2)
... 'FLAC', 16000, source_uri='gs://my-bucket/recording.flac',
... language_code='en-GB', max_alternatives=2, )

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

docs/speech-usage.rst
... print('transcript: ' + alternative['transcript'])
... print('confidence: ' + alternative['confidence'])
====================
transcript: Hello, this is a f****** test

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

speech/google/cloud/speech/client.py
@@ -46,26 +46,17 @@ class Client(client_module.Client):

_connection_class = Connection

def async_recognize(self, content, source_uri, encoding, sample_rate,
def async_recognize(self, encoding, sample_rate, content=None,

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

speech/google/cloud/speech/client.py
@@ -80,6 +71,9 @@ def async_recognize(self, content, source_uri, encoding, sample_rate,
native sample rate of the audio source (instead of
re-sampling).

:type content: bytes
:param content: Byte stream of audio.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

speech/google/cloud/speech/client.py
@@ -99,6 +93,13 @@ def async_recognize(self, content, source_uri, encoding, sample_rate,
asterisks, e.g. ``'f***'``. If False or
omitted, profanities won't be filtered out.

:type source_uri: str
:param source_uri: URI that points to a file that contains audio

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@daspecster daspecster force-pushed the cleanup-speech branch 2 times, most recently from 0a585b5 to b472c07 Compare October 5, 2016 05:47
@daspecster
Copy link
Contributor Author

Updated! LMKWYT @dhermes @tseaver

@daspecster
Copy link
Contributor Author

Also @dhermes if you want I can hold off on this if you want #2500 in first.

@daspecster
Copy link
Contributor Author

@dhermes was there anything else on this?

dhermes
dhermes reviewed Oct 6, 2016
View reviewed changes
speech/google/cloud/speech/__init__.py
@@ -15,5 +15,4 @@
"""Google Cloud Speech API wrapper."""

from google.cloud.speech.client import Client
from google.cloud.speech.client import Encoding

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Oct 6, 2016

@daspecster I haven't followed since @tseaver requested the Sample class. If he is OK with the changes I am OK with them.

tseaver
tseaver reviewed Oct 6, 2016
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to the Sample class LGTM. Do we need to add a Client.sample() factory (basically to ease the developer's need to do extra imports).

@daspecster
Copy link
Contributor Author

@tseaver I think you may have eluded to that in your sample and I didn't make the connection so I took that out.

I'll add that and push it back up.

@daspecster
Copy link
Contributor Author

@tseaver added the @staticmethod on speech.client.Client. LMKWYT!

@daspecster
Copy link
Contributor Author

Thanks @tseaver!

@daspecster daspecster merged commit fb10016 into googleapis:master Oct 6, 2016
@daspecster daspecster deleted the cleanup-speech branch October 6, 2016 19:28
@daspecster daspecster mentioned this pull request Oct 6, 2016
Closed
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@daspecster
Merge pull request googleapis#2495 from daspecster/cleanup-speech
db307dc 
Updates from googleapis#2344 for speech API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes requested changes

@tseaver tseaver tseaver approved these changes

Assignees

@tseaver tseaver

Labels
api: speech Issues related to the Speech-to-Text API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daspecster @dhermes @tseaver @googlebot