Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Google Cloud Storage bucket classes. #2571

Merged
merged 2 commits into from
Oct 20, 2016

Conversation

y33zhang
Copy link
Contributor

product refresh

refresh 10/20
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 19, 2016
@y33zhang
Copy link
Contributor Author

I work at google (yyzhang@google.com). please grant me cla. thanks

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@theacodes
Copy link
Contributor

@y33zhang for CLA bot to recognize you, you need to register your github username at go/github and use your @google.com address to author your commits.

@daspecster daspecster changed the title product refresh Update Google Cloud Storage bucket classes. Oct 19, 2016
@y33zhang
Copy link
Contributor Author

ahh, noob github user here ;). Is there a way to retroactively set my google.com address on previous commits?

@daspecster
Copy link
Contributor

@y33zhang, yeah you can git commit --amend --author="Author Name <email@address.com>".

@y33zhang
Copy link
Contributor Author

@daspecster thanks a lot, just amended the commit email address. Is there anything else I need to do to get past the cla check?

@@ -842,6 +842,27 @@ def test_storage_class_setter_NEARLINE(self):
self.assertEqual(bucket.storage_class, 'NEARLINE')
self.assertTrue('storageClass' in bucket._changes)

def test_storage_class_setter_COLDINE(self):

This comment was marked as spam.

@dhermes
Copy link
Contributor

dhermes commented Oct 19, 2016

Well that was easy! LGTM modulo the misspelling.

We can merge over the CLA-bot issue.

@daspecster
Copy link
Contributor

I couldn't find those new types in the API docs?

fix spelling
@y33zhang
Copy link
Contributor Author

@daspecster - those are getting updated later today

@y33zhang
Copy link
Contributor Author

@dhermes - still can't get cla check to pass. can you help merge over the cla issue? thanks!

@dhermes dhermes merged commit 881a953 into googleapis:master Oct 20, 2016
@y33zhang
Copy link
Contributor Author

@dhermes - can you help provide an ETA on when the docs will be refreshed/updated on the live site? Thanks!

@dhermes
Copy link
Contributor

dhermes commented Oct 21, 2016

https://googlecloudplatform.github.io/google-cloud-python/latest/storage-buckets.html#google.cloud.storage.bucket.Bucket.storage_class
https://googlecloudplatform.github.io/google-cloud-python/latest/storage-blobs.html#google.cloud.storage.blob.Blob.storage_class


You just made me realize that readthedocs.org is not picking up the correct version (probably due to dependency caching). When I fix that the RTD docs will also be updated at:

http://google-cloud-python.readthedocs.io/en/latest/storage-buckets.html
http://google-cloud-python.readthedocs.io/en/latest/storage-blobs.html


Just because the docs are updated doesn't mean the google-cloud-storage package on PyPI is. We'd need to do a release for that.

richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
Update Google Cloud Storage bucket classes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants