-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remapping (almost) all RPC status codes to our exceptions in datastore. #2590
Conversation
@@ -220,6 +237,44 @@ def allocate_ids(self, project, request_pb): | |||
_datastore_pb2.AllocateIdsResponse) | |||
|
|||
|
|||
def _grpc_catch_rendezvous(to_call, *args, **kwargs): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@jonparrott @daspecster PTAL |
I like this better IMHO. |
FYI I am toying with Circle CI. Looks like Travis is being helpful for the time being though |
Sorry to be late to the party. Wouldn't the |
@tseaver I intentionally didn't do that, mindful of two things:
|
@dhermes FWIW, anywhere we are currently sniffing at core/google/cloud/_testing.py
core/google/cloud/streaming/exceptions.py
core/google/cloud/streaming/http_wrapper.py
core/unit_tests/streaming/test_http_wrapper.py
datastore/google/cloud/datastore/_generated/datastore_grpc_pb2.py
datastore/google/cloud/datastore/connection.py
datastore/unit_tests/test_connection.py
docs/error-reporting-usage.rst
error_reporting/google/cloud/error_reporting/client.py
error_reporting/unit_tests/test_client.py
logging/google/cloud/logging/_gax.py
pubsub/google/cloud/pubsub/_gax.py |
OK. |
Remapping (almost) all RPC status codes to our exceptions in datastore.
Fixes #2497.
(Relevant to #2583 as well.)
FYI @jonparrott