Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Iterator.pages and simplify items iteration #2594

Merged
merged 8 commits into from
Oct 25, 2016
Merged

Implement Iterator.pages and simplify items iteration #2594

merged 8 commits into from
Oct 25, 2016

Commits on Oct 25, 2016

  1. Adding a pages iterator side-by-side with items iterator.

    @dhermes
    dhermes committed Oct 25, 2016
    Configuration menu
    Copy the full SHA
    61a1476 View commit details
    Browse the repository at this point in the history

  2. Using the pages iterator in the main iterator. 

    NOTE: There is a current mismatch between incrementing
Iterator.num_results in Iterator.__iter__ vs. incrementing
it in Iterator.pages (there it won't be incremented, so this
will need to be addressed in a subsequent commit).
    @dhermes
    dhermes committed Oct 25, 2016
    Configuration menu
    Copy the full SHA
    1d38abb View commit details
    Browse the repository at this point in the history

  3. Remove some manual paging functionality.

    @dhermes
    dhermes committed Oct 25, 2016
    Configuration menu
    Copy the full SHA
    fbdd73a View commit details
    Browse the repository at this point in the history

  4. Properly tracking the Iterator #results in pages/items iterators.

    @dhermes
    dhermes committed Oct 25, 2016
    Configuration menu
    Copy the full SHA
    d349afb View commit details
    Browse the repository at this point in the history

  5. Updating Iterator/paging documentation.

    @dhermes
    dhermes committed Oct 25, 2016
    Configuration menu
    Copy the full SHA
    8f81dcc View commit details
    Browse the repository at this point in the history

  6. Updating core unit tests for Iterator changes. 

    Also moving __iter__ functionality into a helper
so that the "started?" check could be done **before**
entering the generator. This is because the "self.pages"
generator wouldn't be entered until an item was consumed
off the items iterator.
    @dhermes
    dhermes committed Oct 25, 2016
    Configuration menu
    Copy the full SHA
    57a3c49 View commit details
    Browse the repository at this point in the history

  7. Fixing unit tests for Iterator dependent packages.

    @dhermes
    dhermes committed Oct 25, 2016
    Configuration menu
    Copy the full SHA
    a6890c5 View commit details
    Browse the repository at this point in the history

  8. Fixing use of Iterator in storage system tests.

    @dhermes
    dhermes committed Oct 25, 2016
    Configuration menu
    Copy the full SHA
    9a504c6 View commit details
    Browse the repository at this point in the history