Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for pycodestyle. #2973

Merged
merged 6 commits into from
Jan 31, 2017
Merged

Updates for pycodestyle. #2973

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2b34b40
Update bare exceptions.
daspecster Jan 30, 2017
2561013
Ignore pycodestyle E306,E123,E722.
daspecster Jan 30, 2017
0340188
Locally disable E722 for transaction.py.
daspecster Jan 30, 2017
b489c4b
Fix E123 pycodestyle issues.
daspecster Jan 30, 2017
6d15ee9
Remove pycodestyle ignore.
daspecster Jan 31, 2017
aeeead9
Update noqa with description.
daspecster Jan 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bigquery/unit_tests/test_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -838,7 +838,7 @@ def api_request(self, **kw):

try:
response, self._responses = self._responses[0], self._responses[1:]
except:
except IndexError:
raise NotFound('miss')
else:
return response
2 changes: 1 addition & 1 deletion bigquery/unit_tests/test_job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1904,7 +1904,7 @@ def api_request(self, **kw):

try:
response, self._responses = self._responses[0], self._responses[1:]
except:
except IndexError:
raise NotFound('miss')
else:
return response
2 changes: 1 addition & 1 deletion bigquery/unit_tests/test_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1989,7 +1989,7 @@ def api_request(self, **kw):

try:
response, self._responses = self._responses[0], self._responses[1:]
except:
except IndexError:
raise NotFound('miss')
else:
return response
Expand Down
2 changes: 1 addition & 1 deletion datastore/google/cloud/datastore/transaction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ def begin(self):
try:
self._id = self._client._connection.begin_transaction(
self.project)
except:
except: # noqa: E722

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

self._status = self._ABORTED
raise

Expand Down
2 changes: 1 addition & 1 deletion dns/unit_tests/test_changes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ def api_request(self, **kw):

try:
response, self._responses = self._responses[0], self._responses[1:]
except:
except IndexError:
raise NotFound('miss')
else:
return response
2 changes: 1 addition & 1 deletion dns/unit_tests/test_zone.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,7 +693,7 @@ def api_request(self, **kw):

try:
response, self._responses = self._responses[0], self._responses[1:]
except:
except IndexError:
raise NotFound('miss')
else:
return response
2 changes: 1 addition & 1 deletion resource_manager/unit_tests/test_project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ def api_request(self, **kw):

try:
response, self._responses = self._responses[0], self._responses[1:]
except:
except IndexError:
raise NotFound('miss')
else:
return response
Expand Down
2 changes: 1 addition & 1 deletion runtimeconfig/unit_tests/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ def api_request(self, **kw):

try:
response, self._responses = self._responses[0], self._responses[1:]
except:
except IndexError:
raise NotFound('miss')
else:
return response
2 changes: 1 addition & 1 deletion runtimeconfig/unit_tests/test_variable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ def api_request(self, **kw):

try:
response, self._responses = self._responses[0], self._responses[1:]
except:
except IndexError:
raise NotFound('miss')
else:
return response
3 changes: 2 additions & 1 deletion scripts/pycodestyle_on_repo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ def main():
if not python_files:
print('No Python files to lint, exiting.')
else:
pycodestyle_command = ['pycodestyle'] + python_files
pycodestyle_command = ['pycodestyle',
'--ignore=E306,E123'] + python_files

This comment was marked as spam.

Sign in to view

status_code = subprocess.call(pycodestyle_command)
sys.exit(status_code)

Expand Down
2 changes: 1 addition & 1 deletion storage/unit_tests/test_bucket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1098,7 +1098,7 @@ def api_request(self, **kw):

try:
response, self._responses = self._responses[0], self._responses[1:]
except:
except IndexError:
raise NotFound('miss')
else:
return response
Expand Down