Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage release 0.23.1 #3111

Merged
merged 1 commit into from
Mar 6, 2017
Merged

Storage release 0.23.1 #3111

merged 1 commit into from
Mar 6, 2017

Conversation

daspecster
Copy link
Contributor

Storage 0.23.1

@daspecster daspecster added the api: storage Issues related to the Cloud Storage API. label Mar 6, 2017
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Mar 6, 2017
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Mar 6, 2017
@daspecster daspecster changed the title Release storage-0.23.1 Storage release 0.23.1 Mar 6, 2017
@daspecster daspecster merged commit c37ab7f into googleapis:master Mar 6, 2017
@daspecster daspecster deleted the storage-0.23.1 branch March 6, 2017 22:18
@daspecster
Copy link
Contributor Author

Release tag: https://github.com/GoogleCloudPlatform/google-cloud-python/releases/tag/storage-0.23.1

@tseaver
Copy link
Contributor

tseaver commented Mar 7, 2017

I'm still sad about releasing features in a third-dot.

@daspecster
Copy link
Contributor Author

So this didn't really qualify as a patch?

@tseaver
Copy link
Contributor

tseaver commented Mar 7, 2017

It adds a method / exposes a new API feature (assigning a storage class to a blob). The issue is that cod written to use the feature will break if used with an earlier version of the same 0.23 release line.

@daspecster
Copy link
Contributor Author

daspecster commented Mar 7, 2017 •
edited
Loading

So you're saying it should have been 0.24? (Which is contrary to semver as well...but probably closer to correct)

@tseaver
Copy link
Contributor

tseaver commented Mar 7, 2017

That would've been my preference. @lukesneeringer has a different take on it, though.

richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@daspecster
Merge pull request googleapis#3111 from daspecster/storage-0.23.1
b53896a 
Storage release 0.23.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukesneeringer lukesneeringer lukesneeringer approved these changes

@tseaver tseaver Awaiting requested review from tseaver

@dhermes dhermes Awaiting requested review from dhermes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daspecster @googlebot @tseaver @lukesneeringer