Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not force LRO to be FLAC only in Speech. #3291

Merged
merged 1 commit into from
Apr 12, 2017
Merged

Do not force LRO to be FLAC only in Speech. #3291

merged 1 commit into from
Apr 12, 2017

Conversation

lukesneeringer
Copy link
Contributor

Fixes #3285

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 12, 2017
dhermes
dhermes approved these changes Apr 12, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though I think the PR title is wrong? (Is FLAC the same as LINEAR16?)

@lukesneeringer lukesneeringer merged commit f7d74ca into googleapis:master Apr 12, 2017
@lukesneeringer
Copy link
Contributor Author

Fixed in the squash commit.

@lukesneeringer lukesneeringer deleted the issue-3285 branch April 12, 2017 20:33
@lukesneeringer lukesneeringer mentioned this pull request Apr 13, 2017
Merged
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@lukesneeringer
Do not force LRO to be LINEAR16 only in Speech. (googleapis#3291)
2af68e3 
Fixes googleapis#3285
atulep pushed a commit that referenced this pull request Apr 3, 2023
@lukesneeringer
Do not force LRO to be LINEAR16 only in Speech. (#3291)
3b3c771 
Fixes #3285
atulep pushed a commit that referenced this pull request Apr 18, 2023
@lukesneeringer
Do not force LRO to be LINEAR16 only in Speech. (#3291)
07284cd 
Fixes #3285
parthea pushed a commit that referenced this pull request Oct 22, 2023
@lukesneeringer
Do not force LRO to be LINEAR16 only in Speech. (#3291)
6343af2 
Fixes #3285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukesneeringer @dhermes @googlebot