Add bucket versioning support #340

tseaver · 2014-11-04T19:25:08Z

Presumes #339 is merged to master already (merged on this branch).

See: https://cloud.google.com/storage/docs/object-versioning

Addresses the 'logging' field described in of #314.

coveralls · 2014-11-04T19:33:23Z

Coverage remained the same when pulling 853d79a on tseaver:314-bucket_versioning_support into a410c6a on GoogleCloudPlatform:master.

coveralls · 2014-11-04T19:37:44Z

Coverage remained the same when pulling 853d79a on tseaver:314-bucket_versioning_support into a410c6a on GoogleCloudPlatform:master.

coveralls · 2014-11-04T21:41:53Z

Coverage remained the same when pulling 8b2d533 on tseaver:314-bucket_versioning_support into aa22386 on GoogleCloudPlatform:master.

dhermes · 2014-11-05T01:32:35Z

Please rebase and ping me after so I can review (we can do this and #341, #342 and #344 in a cascade).

See: https://cloud.google.com/storage/docs/object-versioning Addresses part of #314.

tseaver · 2014-11-05T02:08:24Z

@dhermes rebased.

coveralls · 2014-11-05T02:11:47Z

Coverage remained the same when pulling 8477e85 on tseaver:314-bucket_versioning_support into 826ea69 on GoogleCloudPlatform:master.

gcloud/storage/bucket.py

+        :rtype: boolean
+        :returns: True if enabled, else False.
+        """
+        if not self.has_metadata(field='versioning'):


tseaver · 2014-11-05T15:00:33Z

@dhermes can we go ahead and land this one, #341, #342, #343, #344 before factoring out a helper method? I promise to get that factoring in place before tackling the Key properties. :)

tseaver · 2014-11-05T21:55:53Z

Superseded by #347.

* chore: Update gapic-generator-python to v1.8.4 PiperOrigin-RevId: 507808936 Source-Link: googleapis/googleapis@64cf849 Source-Link: googleapis/googleapis-gen@53c48ca Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: https://github.com/googleapis/synthtool/commit/5f2a6089f73abf06238fe4310f6a14d6f6d1eed3 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8555f0e37e6261408f792bfd6635102d2da5ad73f8f09bcb24f25e6afb5fac97

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 472561635 Source-Link: googleapis/googleapis@332ecf5 Source-Link: googleapis/googleapis-gen@4313d68 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDMxM2Q2ODI4ODBmZDlkNzI0NzI5MTE2NGQ0ZTlkM2Q1YmQ5ZjE3NyJ9

Source-Link: googleapis/synthtool@52e4e46 Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:6186535cbdbf6b9fe61f00294929221d060634dae4a0795c1cefdbc995b2d605

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…avior (#340) * docs: clarified wording around the NodePoolUpdateStrategy default behavior docs: add references for available node image types PiperOrigin-RevId: 505182579 Source-Link: googleapis/googleapis@c062caf Source-Link: googleapis/googleapis-gen@ea6906f Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWE2OTA2ZjExYWY1MjQzZDZiNDEwNWFmMGFmODU0ZTg3OGIwYTFlNyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * docs: clarified wording around the NodePoolUpdateStrategy default behavior docs: add references for available node image types PiperOrigin-RevId: 505186848 Source-Link: googleapis/googleapis@d6e9adb Source-Link: googleapis/googleapis-gen@fa221b6 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZmEyMjFiNmEzYzk0NWNhN2VjMDYzYjcyYWU5ZWNhOTQwZWQzZGZkZCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

- [x] Regenerate this pull request now. fix: resolve DuplicateCredentialArgs error when using credentials_file committer: parthea PiperOrigin-RevId: 425964861 Source-Link: googleapis/googleapis@84b1a5a Source-Link: googleapis/googleapis-gen@4fb761b Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGZiNzYxYmJkODUwNmFjMTU2ZjQ5YmFjNWYxODMwNmFhOGViM2FhOCJ9

* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* fix: Add async context manager return types chore: Mock return_value should not populate oneof message fields chore: Support snippet generation for services that only support REST transport chore: Update gapic-generator-python to v1.11.0 PiperOrigin-RevId: 545430278 Source-Link: googleapis/googleapis@601b532 Source-Link: googleapis/googleapis-gen@b3f18d0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjNmMThkMGY2NTYwYTg1NTAyMmZkMDU4ODY1ZTc2MjA0NzlkN2FmOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: https://github.com/googleapis/synthtool/commit/92006bb3cdc84677aa93c7f5235424ec2b157146 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6

…340)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* chore: use gapic-generator-python 1.3.1 PiperOrigin-RevId: 472772457 Source-Link: googleapis/googleapis@855b74d Source-Link: googleapis/googleapis-gen@b64b1e7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjY0YjFlN2RhM2UxMzhmMTVjYTM2MTU1MmVmMDU0NWU1NDg5MWI0ZiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: bump gapic-generator-python to version 1.4.0 PiperOrigin-RevId: 472872910 Source-Link: googleapis/googleapis@89404ee Source-Link: googleapis/googleapis-gen@f19e0dc Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjE5ZTBkYzMyYTUxNzE4ODk2YTk3ZGQ0ZjE5YWNiZWQyMWEzMTllYyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: update to gapic-generator-python 1.5.0 feat: add support for `google.cloud.<api>.__version__` PiperOrigin-RevId: 484665853 Source-Link: googleapis/googleapis@8eb249a Source-Link: googleapis/googleapis-gen@c8aa327 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzhhYTMyN2I1ZjQ3ODg2NWZjM2ZkOTFlM2MyNzY4ZTU0ZTI2YWQ0NCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * update version in gapic_version.py * add .release-please-manifest.json with correct version * set manifest to true in .github/release-please.yml * add release-please-config.json * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: Update to gapic-generator-python 1.6.0 feat(python): Add typing to proto.Message based class attributes feat(python): Snippetgen handling of repeated enum field PiperOrigin-RevId: 487326846 Source-Link: googleapis/googleapis@da380c7 Source-Link: googleapis/googleapis-gen@61ef576 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjFlZjU3NjJlZTY3MzFhMGNiYmZlYTIyZmQwZWVjZWU1MWFiMWM4ZSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: new APIs added to reflect updates to the filestore service - Add ENTERPRISE Tier - Add snapshot APIs: RevertInstance, ListSnapshots, CreateSnapshot, DeleteSnapshot, UpdateSnapshot - Add multi-share APIs: ListShares, GetShare, CreateShare, DeleteShare, UpdateShare - Add ConnectMode to NetworkConfig (for Private Service Access support) - New status codes (SUSPENDED/SUSPENDING, REVERTING/RESUMING) - Add SuspensionReason (for KMS related suspension) - Add new fields to Instance information: max_capacity_gb, capacity_step_size_gb, max_share_count, capacity_gb, multi_share_enabled PiperOrigin-RevId: 487492758 Source-Link: googleapis/googleapis@5be5981 Source-Link: googleapis/googleapis-gen@ab0e217 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWIwZTIxN2Y1NjBjYzJjMWFmYzExNDQxYzJlYWI2YjY5NTBlZmQyYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * update path to snippet metadata json * chore: Update gapic-generator-python to v1.6.1 PiperOrigin-RevId: 488036204 Source-Link: googleapis/googleapis@08f275f Source-Link: googleapis/googleapis-gen@555c094 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTU1YzA5NDVlNjA2NDllMzg3MzlhZTY0YmM0NTcxOWNkZjcyMTc4ZiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * use templated owlbot.py and setup.py * exclude generated constraints file * exclude autogenerated setup.py * update replacements in owlbot.py * run nox format session Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 472561635 Source-Link: googleapis/googleapis@332ecf5 Source-Link: googleapis/googleapis-gen@4313d68 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDMxM2Q2ODI4ODBmZDlkNzI0NzI5MTE2NGQ0ZTlkM2Q1YmQ5ZjE3NyJ9

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore: update copyright year to 2022 PiperOrigin-RevId: 431037888 Source-Link: googleapis/googleapis@b3397f5 Source-Link: googleapis/googleapis-gen@510b54e Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTEwYjU0ZTFjZGVmZDUzMTczOTg0ZGYxNjY0NTA4MTMwOGZlODk3ZSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

tseaver added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Nov 4, 2014

tseaver removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 4, 2014

tseaver added 2 commits November 4, 2014 21:06

Add support for the Bucket's 'versioning' field.

d52d81f

See: https://cloud.google.com/storage/docs/object-versioning Addresses part of #314.

Add tests asserting that 'get_metatdata' raises w/ 'versioning'.

8477e85

dhermes reviewed Nov 5, 2014
View reviewed changes

gcloud/storage/bucket.py

:rtype: boolean

:returns: True if enabled, else False.

"""

if not self.has_metadata(field='versioning'):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tseaver mentioned this pull request Nov 5, 2014

Rename 'metadata' to 'properties' #345

Closed

tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 5, 2014

tseaver mentioned this pull request Nov 5, 2014

Pull in / reconcile all PRs for #314 #347

Merged

tseaver closed this Nov 5, 2014

tseaver deleted the 314-bucket_versioning_support branch November 6, 2014 22:43

atulep pushed a commit that referenced this pull request Apr 6, 2023

chore(deps): update dependency pytest to v7.1.0 (#340)

4f51b7b

atulep pushed a commit that referenced this pull request Apr 6, 2023

chore(deps): update dependency pytest to v7.1.0 (#340)

6c2ee8f

atulep pushed a commit that referenced this pull request Apr 18, 2023

chore(deps): update dependency pytest to v7.1.0 (#340)

e5c79a7

parthea pushed a commit that referenced this pull request Jul 6, 2023

chore(main): release 2.5.1 (#340)

2486171

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(main): release 1.13.1 (#340)

06ece50

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(main): release 1.10.0 (#340)

7580a0a

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency google-cloud-texttospeech to v2.12.3 (#…

b6e887d

…340)

parthea added a commit that referenced this pull request Sep 22, 2023

chore(main): release 2.8.0 (#340)

2d1a81e

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-storage to v1.43.0 (#340)

0c57cad

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(main): release 0.17.0 (#340)

37505c2

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-auth to v2.11.1 (#340)

81570e7

parthea pushed a commit that referenced this pull request Oct 22, 2023

chore(deps): update dependency pytest to v7.1.0 (#340)

4e95744

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add bucket versioning support #340

Add bucket versioning support #340

tseaver commented Nov 4, 2014

coveralls commented Nov 4, 2014

coveralls commented Nov 4, 2014

coveralls commented Nov 4, 2014

dhermes commented Nov 5, 2014

tseaver commented Nov 5, 2014

coveralls commented Nov 5, 2014

This comment was marked as spam.

This comment was marked as spam.

tseaver commented Nov 5, 2014

tseaver commented Nov 5, 2014

Add bucket versioning support #340

Add bucket versioning support #340

Conversation

tseaver commented Nov 4, 2014

coveralls commented Nov 4, 2014

coveralls commented Nov 4, 2014

coveralls commented Nov 4, 2014

dhermes commented Nov 5, 2014

tseaver commented Nov 5, 2014

coveralls commented Nov 5, 2014

This comment was marked as spam.

This comment was marked as spam.

tseaver commented Nov 5, 2014

tseaver commented Nov 5, 2014