Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back pylint as info-only for core #3515

Merged
merged 2 commits into from
Jun 22, 2017
Merged

Add back pylint as info-only for core #3515

merged 2 commits into from
Jun 22, 2017

Conversation

theacodes
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 20, 2017
dhermes
dhermes reviewed Jun 20, 2017
View reviewed changes
core/nox.py Outdated
'--library-filesets', 'google',
'--test-filesets', 'tests',
# Temporarily allow this to fail.
success_codes=range(0, 100))

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

core/nox.py
session.install('.')
session.run('flake8', 'google/cloud/core')
session.run(
'gcp-devrel-py-tools', 'run-pylint',

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@theacodes
Copy link
Contributor Author

@dhermes added a "empty" config file for you. PTAL?

dhermes
dhermes reviewed Jun 22, 2017
View reviewed changes
core/pylint.config.py
# Test configuration

# test_additions = copy.deepcopy(library_additions)
# test_replacements = copy.deepcopy(library_replacements)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Jun 22, 2017

This LGTM.

@theacodes theacodes merged commit 46ced00 into googleapis:master Jun 22, 2017
@theacodes theacodes deleted the pylint-for-core branch June 22, 2017 19:46
@theacodes
Copy link
Contributor Author

Cool, I'll send another PR to add this to all the other packages.

@dhermes
Copy link
Contributor

dhermes commented Jun 22, 2017

SGTM. Do we think @lukesneeringer cares? (Prepare for some lint violations since we've had it turned off.)

@theacodes
Copy link
Contributor Author

theacodes commented Jun 22, 2017 via email •
edited by dhermes
Loading

@dhermes
Copy link
Contributor

dhermes commented Jun 22, 2017

Boom roasted

@tseaver tseaver mentioned this pull request Jun 26, 2017
Merged
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
@landrito
Add back pylint as info-only for core (googleapis#3515)
4993148
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@landrito
Add back pylint as info-only for core (googleapis#3515)
26398aa
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@landrito
Add back pylint as info-only for core (googleapis#3515)
c1f9f4f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes left review comments

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theacodes @dhermes @googlebot