Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing vendored in google.cloud.streaming. #3654

Merged
merged 2 commits into from
Jul 21, 2017
Merged

Removing vendored in google.cloud.streaming. #3654

merged 2 commits into from
Jul 21, 2017

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jul 21, 2017 •
edited
Loading

Done simply via:

$ git rm -fr core/google/cloud/streaming/
$ git rm -fr core/tests/unit/streaming/

Towards #1998.

@dhermes dhermes added api: bigquery Issues related to the BigQuery API. api: storage Issues related to the Cloud Storage API. hygiene labels Jul 21, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 21, 2017
@dhermes dhermes mentioned this pull request Jul 21, 2017
Closed
@theacodes
Copy link
Contributor

This LGTM - if any test failures arise can we address those in separate PRs and rebase this one along?

@theacodes
Copy link
Contributor

Also this won't run system tests - can we verify system tests for impact packages?

@dhermes
Copy link
Contributor Author

dhermes commented Jul 21, 2017

@jonparrott I just pushed https://github.com/GoogleCloudPlatform/google-cloud-python/tree/remove-streaming so we can run system tests.

FWIW the "first run" after merging #3555 failed due to BigQuery timeouts (no idea why).

@dhermes
Copy link
Contributor Author

dhermes commented Jul 21, 2017

OK https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/2515 and https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/2511 have failed in the same way, but at HEAD, the system tests continue to pass on my local machine (even when setting CIRCLE_BUILD_NUM).

I added a "nonsense" commit to force pytest to emit native Python tracebacks (I have never gotten used to pytest tracebacks)

@dhermes
Copy link
Contributor Author

dhermes commented Jul 21, 2017

As a small solace, the unit tests are all good:

https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/tree/pull%2F3654

@dhermes
Copy link
Contributor Author

dhermes commented Jul 21, 2017

I think the BigQuery issue is just some intermittent failures in BigQuery. The latest build (https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/2518) only failed in 3.6 and only on one test case.

@theacodes
Copy link
Contributor

theacodes commented Jul 21, 2017 via email

@dhermes
Copy link
Contributor Author

dhermes commented Jul 21, 2017

Haha OK!

@dhermes dhermes merged commit 0414ef1 into googleapis:master Jul 21, 2017
@dhermes dhermes deleted the remove-streaming branch July 21, 2017 23:20
@dhermes
Copy link
Contributor Author

dhermes commented Jul 21, 2017

As suspected, BigQuery unit tests are back to passing: https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/2520

Though those logging tests seem determined to never pass

@theacodes
Copy link
Contributor

theacodes commented Jul 21, 2017 via email •
edited by dhermes
Loading

@dhermes
Copy link
Contributor Author

dhermes commented Jul 22, 2017

I do mean system tests, thank you

@theacodes
Copy link
Contributor

theacodes commented Jul 22, 2017 via email •
edited by dhermes
Loading

This was referenced Jul 31, 2017
Closed
Closed
This was referenced Aug 4, 2017
Merged
Merged
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
@dhermes @landrito
Removing vendored in google.cloud.streaming. (googleapis#3654)
f9c9f2e 
* Removing vendored in google.cloud.streaming.

* Modifying setup.cfg so pytest errors are sane.

This is **not** to be merged, just to debug the b0rken build:
https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/2515
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@dhermes @landrito
Removing vendored in google.cloud.streaming. (googleapis#3654)
6880c9f 
* Removing vendored in google.cloud.streaming.

* Modifying setup.cfg so pytest errors are sane.

This is **not** to be merged, just to debug the b0rken build:
https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/2515
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@dhermes @landrito
Removing vendored in google.cloud.streaming. (googleapis#3654)
49a012b 
* Removing vendored in google.cloud.streaming.

* Modifying setup.cfg so pytest errors are sane.

This is **not** to be merged, just to debug the b0rken build:
https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/2515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes theacodes approved these changes

Assignees

@lukesneeringer lukesneeringer

@tseaver tseaver

@theacodes theacodes

Labels
api: bigquery Issues related to the BigQuery API. api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dhermes @theacodes @lukesneeringer @tseaver @googlebot