-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix url encoding of list parameters #3657
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@isra17 Thanks for the patch! Can you please add a unit test (like the one in your example above) which fails when 'query_params' contains a list value?
Couldn't really add a test from my initial example since API tests rely on mocking, but I modified the |
@isra17 Thank you very much! |
Issue can easily be reproduce with API using list parameters such as
testIamPermissions
in Cloud Storage.Before the fix, using a list end up with this error: