Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove QueryJob.results() #3661

Merged
merged 2 commits into from
Jul 24, 2017
Merged

Remove QueryJob.results() #3661

merged 2 commits into from
Jul 24, 2017

Conversation

theacodes
Copy link
Contributor

Resolves #3652

@theacodes theacodes requested review from tswast and dhermes July 24, 2017 20:53
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 24, 2017
dhermes
dhermes approved these changes Jul 24, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bigquery/google/cloud/bigquery/dbapi/cursor.py Outdated
@@ -17,6 +17,7 @@
import collections
import uuid

import google.cloud.exceptions

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@theacodes theacodes merged commit 40a3b49 into googleapis:master Jul 24, 2017
@theacodes theacodes deleted the remove-bigquery-result branch July 24, 2017 21:17
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
@landrito
Remove QueryJob.results() (googleapis#3661)
3c63c64
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@landrito
Remove QueryJob.results() (googleapis#3661)
77d9221
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@landrito
Remove QueryJob.results() (googleapis#3661)
2f1fda3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes approved these changes

@tswast tswast Awaiting requested review from tswast

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theacodes @dhermes @googlebot