Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump storage to 1.4.0 #3869

Merged
merged 2 commits into from
Aug 24, 2017
Merged

Conversation

lukesneeringer
Copy link
Contributor

Release notes:

@lukesneeringer lukesneeringer self-assigned this Aug 24, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2017
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Worth noting: Your release note style is somewhat different than what I've used over the years. This is neither good nor bad, just worth noting. (You can design a "sentiment" if you please.)

@lukesneeringer
Copy link
Contributor Author

lukesneeringer commented Aug 24, 2017

Tacking to your style for now; can discuss at repo split but I think what you are doing is fine. (Eventually I may want to automate it.)

@lukesneeringer lukesneeringer merged commit ce9ca35 into googleapis:master Aug 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants