Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'BucketNotification.delete' API wrapper. #3983

Merged
merged 2 commits into from
Sep 16, 2017
Merged

Add 'BucketNotification.delete' API wrapper. #3983

merged 2 commits into from
Sep 16, 2017

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 15, 2017

Toward #3956.

@tseaver tseaver added api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Sep 15, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 15, 2017
This was referenced Sep 15, 2017
Closed
Closed
dhermes
dhermes approved these changes Sep 15, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

storage/google/cloud/storage/notification.py
to the ``client`` stored on the current bucket.

:raises: :class:`google.api.core.exceptions.NotFound`:
if the notification does not exist.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver tseaver merged commit 0a2a40f into googleapis:3956-storage-notifications Sep 16, 2017
@tseaver tseaver deleted the 3956-storage-notifications-notification-delete branch September 16, 2017 04:49
@tseaver tseaver mentioned this pull request Sep 18, 2017
Merged
tseaver added a commit that referenced this pull request Sep 25, 2017
@tseaver
Add 'BucketNotification.delete' API wrapper. (#3983)
6f3c1e0 
Toward #3956.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot