Move the admin database GAPIC to source delivery. #4029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 22, 2017 07:46
* Remove dependency on gapic-google-cloud-spanner-admin-database-v1 * Update imports
googlebot
added
the
cla: yes
lukesneeringer
added
api: spanner
lukesneeringer
force-pushed
the
spanner-admin-db-gapic
branch
from
caf9402
to
9a33093
Compare
tseaver
reviewed
Sep 22, 2017
| timestamp_pb2, | ||
| status_pb2, ): | ||
| for name, message in get_messages(module).items(): | ||
| message.__module__ = 'google.cloud.spanner_admin_database_v1.types' |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tseaver
reviewed
Sep 22, 2017
| 'gapic-google-cloud-spanner-v1 >= 0.15.0, < 0.16dev', | ||
| 'gapic-google-cloud-spanner-admin-database-v1 >= 0.15.0, < 0.16dev', | ||
| 'gapic-google-cloud-spanner-admin-instance-v1 >= 0.15.0, < 0.16dev', |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
lukesneeringer
force-pushed
the
spanner-admin-db-gapic
branch
from
9a33093
to
5d2510c
Compare
tseaver
reviewed
Sep 22, 2017
| @@ -51,12 +51,14 @@ | |||
|
|
|||
|
|
|||
| REQUIREMENTS = [ | |||
| 'google-cloud-core >= 0.27.0, < 0.28dev', | |||
| 'google-auth >= 1.1.0', | |||
| 'grpcio >= 1.2.0, < 2.0dev', | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tseaver
approved these changes
Sep 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses #4028 as a base.
Commit-by-commit recommended as the review path.