Retry whole batch of deletes on 429. #4032
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
CircleCI failures are unrelated vision flakiness (#4035). |
Because 'Bucket.delete' inside a batch context manager is deferred, we cannot retry it directly. We also need to check for bucket existence, as the bucket *may* have been deleted in the previous batch before the 429 was raised. Closes #3761.
tseaver
force-pushed
the
3761-storage-flaky-systest-cleanup
branch
from
aadbe77
to
bccc5bc
Compare
|
Rebased after merge of #4050. Fingers crossed. |
lukesneeringer
approved these changes
Sep 25, 2017
|
@tseaver ISTM we should just drop the batch. |
|
Superseded by #4102. |
tseaver
added a commit
that referenced
this pull request
Oct 2, 2017
Allows 429 errors to be handled by retry. See: #4032 (comment)
crwilcox
pushed a commit
to googleapis/python-storage
that referenced
this pull request
Jan 31, 2020
Allows 429 errors to be handled by retry. See: googleapis/google-cloud-python#4032 (comment)
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
Allows 429 errors to be handled by retry. See: googleapis/google-cloud-python#4032 (comment)
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
Allows 429 errors to be handled by retry. See: googleapis/google-cloud-python#4032 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
Bucket.deleteinside a batch context manager is deferred, we cannot retry it directly. We also need to check for bucket existence, as the bucket may have been deleted successfully in the previous batch before the 429 was raised.Closes #3761.