-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add google.api.core.helpers.grpc_helpers #4041
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,104 @@ | ||
# Copyright 2017 Google Inc. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
"""Helpers for :mod:`grpc`.""" | ||
|
||
import grpc | ||
import six | ||
|
||
from google.api.core import exceptions | ||
|
||
|
||
# The list of gRPC Callable interfaces that return iterators. | ||
_STREAM_WRAP_CLASSES = ( | ||
grpc.UnaryStreamMultiCallable, | ||
grpc.StreamStreamMultiCallable, | ||
) | ||
|
||
|
||
def _patch_callable_name(callable): | ||
"""Fix-up gRPC callable attributes. | ||
|
||
gRPC callable lack the ``__name__`` attribute which causes | ||
:func:`functools.wraps` to error. This adds the attribute if needed. | ||
""" | ||
if not hasattr(callable, '__name__'): | ||
callable.__name__ = callable.__class__.__name__ | ||
|
||
|
||
def _wrap_unary_errors(callable): | ||
"""Map errors for Unary-Unary and Stream-Unary gRPC callables.""" | ||
_patch_callable_name(callable) | ||
|
||
@six.wraps(callable) | ||
def error_remapped_callable(*args, **kwargs): | ||
try: | ||
return callable(*args, **kwargs) | ||
except grpc.RpcError as exc: | ||
six.raise_from(exceptions.from_grpc_error(exc), exc) | ||
|
||
return error_remapped_callable | ||
|
||
|
||
def _wrap_stream_errors(callable): | ||
"""Wrap errors for Unary-Stream and Stream-Stream gRPC callables. | ||
|
||
The callables that return iterators require a bit more logic to re-map | ||
errors when iterating. This wraps both the initial invocation and the | ||
iterator of the return value to re-map errors. | ||
""" | ||
_patch_callable_name(callable) | ||
|
||
@six.wraps(callable) | ||
def error_remapped_callable(*args, **kwargs): | ||
try: | ||
result = callable(*args, **kwargs) | ||
# Note: we are patching the private grpc._channel._Rendezvous._next | ||
# method as magic methods (__next__ in this case) can not be | ||
# patched on a per-instance basis (see | ||
# https://docs.python.org/3/reference/datamodel.html | ||
# #special-lookup). | ||
# In an ideal world, gRPC would return a *specific* interface | ||
# from *StreamMultiCallables, but they return a God class that's | ||
# a combination of basically every interface in gRPC making it | ||
# untenable for us to implement a wrapper object using the same | ||
# interface. | ||
result._next = _wrap_unary_errors(result._next) | ||
return result | ||
except grpc.RpcError as exc: | ||
six.raise_from(exceptions.from_grpc_error(exc), exc) | ||
|
||
return error_remapped_callable | ||
|
||
|
||
def wrap_errors(callable): | ||
"""Wrap a gRPC callable and map :class:`grpc.RpcErrors` to friendly error | ||
classes. | ||
|
||
Errors raised by the gRPC callable are mapped to the appropriate | ||
:class:`google.api.core.exceptions.GoogleAPICallError` subclasses. | ||
The original `grpc.RpcError` (which is usually also a `grpc.Call`) is | ||
available from the ``response`` property on the mapped exception. This | ||
is useful for extracting metadata from the original error. | ||
|
||
Args: | ||
callable (Callable): A gRPC callable. | ||
|
||
Returns: | ||
Callable: The wrapped gRPC callable. | ||
""" | ||
if isinstance(callable, _STREAM_WRAP_CLASSES): | ||
return _wrap_stream_errors(callable) | ||
else: | ||
return _wrap_unary_errors(callable) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,130 @@ | ||
# Copyright 2017 Google Inc. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
import grpc | ||
import mock | ||
import pytest | ||
|
||
from google.api.core import exceptions | ||
from google.api.core.helpers import grpc_helpers | ||
|
||
|
||
def test__patch_callable_name(): | ||
callable = mock.Mock(spec=['__class__']) | ||
callable.__class__ = mock.Mock(spec=['__name__']) | ||
callable.__class__.__name__ = 'TestCallable' | ||
|
||
grpc_helpers._patch_callable_name(callable) | ||
|
||
assert callable.__name__ == 'TestCallable' | ||
|
||
|
||
def test__patch_callable_name_no_op(): | ||
callable = mock.Mock(spec=['__name__']) | ||
callable.__name__ = 'test_callable' | ||
|
||
grpc_helpers._patch_callable_name(callable) | ||
|
||
assert callable.__name__ == 'test_callable' | ||
|
||
|
||
class RpcErrorImpl(grpc.RpcError, grpc.Call): | ||
def __init__(self, code): | ||
super(RpcErrorImpl, self).__init__() | ||
self._code = code | ||
|
||
def code(self): | ||
return self._code | ||
|
||
def details(self): | ||
return None | ||
|
||
|
||
def test_wrap_unary_errors(): | ||
grpc_error = RpcErrorImpl(grpc.StatusCode.INVALID_ARGUMENT) | ||
callable = mock.Mock(spec=['__call__'], side_effect=grpc_error) | ||
|
||
wrapped_callable = grpc_helpers._wrap_unary_errors(callable) | ||
|
||
with pytest.raises(exceptions.InvalidArgument) as exc_info: | ||
wrapped_callable(1, 2, three='four') | ||
|
||
callable.assert_called_once_with(1, 2, three='four') | ||
assert exc_info.value.response == grpc_error | ||
|
||
|
||
def test_wrap_stream_errors_invocation(): | ||
grpc_error = RpcErrorImpl(grpc.StatusCode.INVALID_ARGUMENT) | ||
callable = mock.Mock(spec=['__call__'], side_effect=grpc_error) | ||
|
||
wrapped_callable = grpc_helpers._wrap_stream_errors(callable) | ||
|
||
with pytest.raises(exceptions.InvalidArgument) as exc_info: | ||
wrapped_callable(1, 2, three='four') | ||
|
||
callable.assert_called_once_with(1, 2, three='four') | ||
assert exc_info.value.response == grpc_error | ||
|
||
|
||
class RpcResponseIteratorImpl(object): | ||
def __init__(self, exception): | ||
self._exception = exception | ||
|
||
# Note: This matches grpc._channel._Rendezvous._next which is what is | ||
# patched by _wrap_stream_errors. | ||
def _next(self): | ||
raise self._exception | ||
|
||
def __next__(self): # pragma: NO COVER | ||
return self._next() | ||
|
||
def next(self): # pragma: NO COVER | ||
return self._next() | ||
|
||
|
||
def test_wrap_stream_errors_iterator(): | ||
grpc_error = RpcErrorImpl(grpc.StatusCode.UNAVAILABLE) | ||
response_iter = RpcResponseIteratorImpl(grpc_error) | ||
callable = mock.Mock(spec=['__call__'], return_value=response_iter) | ||
|
||
wrapped_callable = grpc_helpers._wrap_stream_errors(callable) | ||
|
||
got_iterator = wrapped_callable(1, 2, three='four') | ||
|
||
with pytest.raises(exceptions.ServiceUnavailable) as exc_info: | ||
next(got_iterator) | ||
|
||
assert got_iterator == response_iter | ||
callable.assert_called_once_with(1, 2, three='four') | ||
assert exc_info.value.response == grpc_error | ||
|
||
|
||
@mock.patch('google.api.core.helpers.grpc_helpers._wrap_unary_errors') | ||
def test_wrap_errors_non_streaming(wrap_unary_errors): | ||
callable = mock.create_autospec(grpc.UnaryUnaryMultiCallable) | ||
|
||
result = grpc_helpers.wrap_errors(callable) | ||
|
||
assert result == wrap_unary_errors.return_value | ||
wrap_unary_errors.assert_called_once_with(callable) | ||
|
||
|
||
@mock.patch('google.api.core.helpers.grpc_helpers._wrap_stream_errors') | ||
def test_wrap_errors_streaming(wrap_stream_errors): | ||
callable = mock.create_autospec(grpc.UnaryStreamMultiCallable) | ||
|
||
result = grpc_helpers.wrap_errors(callable) | ||
|
||
assert result == wrap_stream_errors.return_value | ||
wrap_stream_errors.assert_called_once_with(callable) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong.