Do not use easily-misread glyphs in Firestore auto-IDs. #4107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tseaver
approved these changes
Oct 3, 2017
|
I can't see how the test failure has anything to do with this change: _______________ test_wrap_method_with_overriding_retry_deadline _______________
Traceback (most recent call last):
File "C:\projects\google-cloud-python\core\tests\unit\api_core\gapic\test_method.py", line 159, in test_wrap_method_with_overriding_retry_deadline
assert timeout_args == [5, 10, 20, 29]
AssertionError: assert [5.0, 10.0, 20.0, 30.0] == [5, 10, 20, 29]
At index 3 diff: 30.0 != 29
Full diff:
- [5.0, 10.0, 20.0, 30.0]
+ [5, 10, 20, 29]
============================== warnings summary ===============================
core/tests/unit/test_iam.py::TestPolicy::test_editors_setter |
This way the entropy is preserved after dropping the alphabet from 62 to 55 characters: >>> (62. / 55.)**20 10.979435205204474 >>> 55**20 < 62**20 < 55**21 True
dhermes
force-pushed
the
autoid-no-confusing-chars
branch
from
e23f4a8
to
7611a97
Compare
|
Likewise going to pull the trigger here. Please let me know if there are objections. |
|
@chemelnucfin Can you revert this? We never got sign off from the Firestore team for this. |
chemelnucfin
added a commit
that referenced
this pull request
Dec 13, 2017
This reverts commit 89c4415.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
{'i', 'I', 'l', 'o', 'O', '0', '1'}from the set of characters used in automatically-generated IDs, because it is easy to mis-read them if you are in a situation where you need to do that.Exact set of blacklisted characters is loaned from Django's
make_random_password./cc @schmidt-sebastian