-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add google.api.core.helpers.general_helpers.wraps #4166
Conversation
@dhermes As an aside, how would you feel if I dropped the |
-0, but they arguably do not need to all end in from google.api.core import helpers
@helpers.general.wraps(thing)
def other_thing My concern is that there will be a lot of helpers things interspersed with other stuff. And while The general helpers could also just go into |
@jonparrott I am big time 👍 on reducing the number of nested packages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I'd like to see a code snippet with the failure you intend to workaround here.
assert replacement() == 42 | ||
|
||
|
||
def test_wraps_partial(): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
I'll send a separate PR to do that. |
Can someone merge this into the bigquery-b2 branch? I'm not sure how to do that. |
@jba I can do it. Will a rebase be OK? |
@tswast What's the right way to get this into bigquery-b2? Maybe just cherry-pick? |
Probably best to rebase bigquery-b2 on master rather than cherry-pick. We'll have to rebase for the final push anyway. |
@tswast I agree. Do you need me to do that or you guys have it covered? |
No description provided.