Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing auth to use implicit environment. #419

Merged
merged 3 commits into from
Dec 16, 2014
Merged

Changing auth to use implicit environment. #419

merged 3 commits into from
Dec 16, 2014

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Dec 16, 2014

FWIW the only real code changes occur in

  • gcloud/credentials.py
  • gcloud/datastore/__init__.py
  • gcloud/datastore/demo/__init__.py
  • gcloud/storage/__init__.py
  • gcloud/storage/connection.py -- Some helpers added here should probably be moved elsewhere. Maybe I file a bug?
  • gcloud/storage/demo/__init__.py
  • regression/regression_utils.py

Also note that googleapis/oauth2client#93 may be problematic for us, but only in the short term (on the order of days).

Also, I still need to update the encrypted environment variables on Travis.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling b4c605a on dhermes:add-better-auth into 31799c3 on GoogleCloudPlatform:master.

tseaver
tseaver reviewed Dec 16, 2014
View reviewed changes
gcloud/storage/test_connection.py
with _Monkey(MUT, crypto=crypto, RSA=rsa, PKCS1_v1_5=pkcs_v1_5,
SHA256=sha256):
SHA256=sha256,
_get_signed_query_params=_get_signed_query_params):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor

tseaver commented Dec 16, 2014

LGTM. Tough that the regression tests don't run on Travis until after the merge, though.

@dhermes
Copy link
Contributor Author

dhermes commented Dec 16, 2014

Tough but worth it for the speed-up. I ran them lots and lots though. I was actually planning on letting them fail once before the new environment variables are set up and then re-running after. WDYT?

@dhermes
Copy link
Contributor Author

dhermes commented Dec 16, 2014

I just pushed 1a1dac0, so we can wait until that passes before merging.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 1a1dac0 on dhermes:add-better-auth into 31799c3 on GoogleCloudPlatform:master.

@tseaver
Copy link
Contributor

tseaver commented Dec 16, 2014

"Fire when ready, Gridley!"

silvolu
silvolu reviewed Dec 16, 2014
View reviewed changes
CONTRIBUTING.rst
authenticating with
- ``GCLOUD_TESTS_KEY_FILE``: The path to an encrypted key file.
See private key
- ``GOOGLE_APPLICATION_CREDENTIALS``: The path to an encrypted JSON file;

This comment was marked as spam.

Sign in to view

@silvolu
Copy link
Contributor

silvolu commented Dec 16, 2014

Looks great! (bar minor comments on wording).
Fixes #247, #335 and #337 right?

@dhermes
Copy link
Contributor Author

dhermes commented Dec 16, 2014

@silvolu addressed the incorrect description in 78adc96

This fixes #247 though that is the very issue @craigcitro and I are trying to sort out in googleapis/oauth2client#93. #335 is in some sense already done but I still plan to

  • Add support and docs for user flow 3-legged auth
  • Add explicit methods for GAE, GCE and user flow. The branching in the implicit get_credentials() is not necessary in a high-performance, specific environment.
  • Add docs for how to use non-default creds / create connections with them.

This does not address #337 in total. I wanted things like

dataset.get_dataset()

to work without having to pass in a dataset ID if one could be implied from the environment i.e. via GCE or GAE specific environ vars / metadata or via an environment variable.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 78adc96 on dhermes:add-better-auth into 31799c3 on GoogleCloudPlatform:master.

@dhermes
Copy link
Contributor Author

dhermes commented Dec 16, 2014

Feel free to merge if there is nothing else to discuss. I am grading a final right now so am a bit MIA.

@tseaver
Copy link
Contributor

tseaver commented Dec 16, 2014

Maybe better not merge until we can figure why the trunk has broken regression tests. Of course, they are passing in my sandbox. Looks like @silvolu kicked off a re-run?

@silvolu
Copy link
Contributor

silvolu commented Dec 16, 2014

@tseaver I did, this one looks extremely transient :)

@silvolu
Copy link
Contributor

silvolu commented Dec 16, 2014

Build is back to green, merging this one.

silvolu added a commit that referenced this pull request Dec 16, 2014
@silvolu
Merge pull request #419 from dhermes/add-better-auth
ae09738 
Changing auth to use implicit environment.
@silvolu silvolu merged commit ae09738 into googleapis:master Dec 16, 2014
@silvolu silvolu mentioned this pull request Dec 16, 2014
Closed
@silvolu
Copy link
Contributor

silvolu commented Dec 16, 2014

There's a decryption error on the credentials, I think @dhermes encrypted the file in his fork. I'll update the credentials file.

@dhermes
Copy link
Contributor Author

dhermes commented Dec 16, 2014

See my previous comment. The GOOGLE_APPLICATION_CREDENTIALS environment variable has not been set yet.

@silvolu
Copy link
Contributor

silvolu commented Dec 16, 2014

@dhermes I've set that variable.

@silvolu
Copy link
Contributor

silvolu commented Dec 16, 2014

Green makes Silvano happy:
https://travis-ci.org/GoogleCloudPlatform/gcloud-python/builds/44267894

@dhermes
Copy link
Contributor Author

dhermes commented Dec 16, 2014

Thanks @silvolu. We are green! w00t

@dhermes dhermes deleted the add-better-auth branch December 17, 2014 00:10
@dhermes dhermes mentioned this pull request Jan 13, 2015
Closed
@dhermes dhermes added auth api: core testing api: datastore Issues related to the Datastore API. api: storage Issues related to the Cloud Storage API. labels Dec 31, 2015
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
chore(python): update release script dependencies [autoapprove] (#419)
add1b8b 
Source-Link: https://github.com/googleapis/synthtool/commit/25083af347468dd5f90f69627420f7d452b6c50e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e6cbd61f1838d9ff6a31436dfc13717f372a7482a82fc1863ca954ec47bff8c8
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
chore(python): exclude path in renovate.json [autoapprove] (#419)
0cfd2f9 
Source-Link: googleapis/synthtool@69fabae
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:562802bfac02e012a6ac34eda282f81d06e77326b82a32d7bbb1369ff552b387
parthea pushed a commit that referenced this pull request Jun 4, 2023
@renovate-bot
chore(deps): update dependency google-cloud-securitycenter to v1.17.0 (…
e3a09b0 
…#419)
parthea pushed a commit that referenced this pull request Jul 6, 2023
@gcf-owl-bot
chore: Update gapic-generator-python to v1.8.4 (#419)
7d660eb 
* chore: Update gapic-generator-python to v1.8.4

PiperOrigin-RevId: 507808936

Source-Link: googleapis/googleapis@64cf849

Source-Link: googleapis/googleapis-gen@53c48ca
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Aug 15, 2023
@nicain
docs: add detect intent with text-to-speech synthesized output snippet (
3753ae3 
#419)

chore: Update test-samples-impl.sh python3.6 --> python3.9 (#418)

Source-Link: googleapis/synthtool@1f07110
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:a5d81b61dfd1a432d3c03f51a25d2e71b37be24da509966d50724aea7c57c5c2

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: nicain <nicholascain@google.com>

fix test
parthea pushed a commit that referenced this pull request Sep 20, 2023
@gcf-owl-bot
chore: remove pinned Sphinx version [autoapprove] (#419)
b373c27 
Source-Link: https://github.com/googleapis/synthtool/commit/909573ce9da2819eeb835909c795d29aea5c724e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ddf4551385d566771dc713090feb7b4c1164fb8a698fe52bbe7670b24236565b
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore(python): add support for python 3.11 (#419)
1891abb 
Source-Link: googleapis/synthtool@7197a00
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c43f1d918bcf817d337aa29ff833439494a158a0831508fda4ec75dc4c0d0320

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@renovate-bot
chore(deps): update all dependencies (#419)
1e93ecd 
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|---|---|
| [actions/setup-python](https://github.com/actions/setup-python) | action | major | `v3` -> `v4` | [![age](https://badges.renovateapi.com/packages/github-tags/actions%2fsetup-python/v4/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/github-tags/actions%2fsetup-python/v4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/github-tags/actions%2fsetup-python/v4/compatibility-slim/v3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/github-tags/actions%2fsetup-python/v4/confidence-slim/v3)](https://docs.renovatebot.com/merge-confidence/) |
| [google-cloud-bigquery](https://github.com/googleapis/python-bigquery) |  | patch | `==3.3.0` -> `==3.3.1` | [![age](https://badges.renovateapi.com/packages/pypi/google-cloud-bigquery/3.3.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/google-cloud-bigquery/3.3.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/google-cloud-bigquery/3.3.1/compatibility-slim/3.3.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/google-cloud-bigquery/3.3.1/confidence-slim/3.3.0)](https://docs.renovatebot.com/merge-confidence/) |
| [protobuf](https://developers.google.com/protocol-buffers/) |  | major | `>= 3.19.0, <4.0.0dev` -> `>=4.21.4, <4.22.0` | [![age](https://badges.renovateapi.com/packages/pypi/protobuf/4.21.4/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/protobuf/4.21.4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/protobuf/4.21.4/compatibility-slim/3.20.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/protobuf/4.21.4/confidence-slim/3.20.1)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>actions/setup-python</summary>

### [`v4`](https://github.com/actions/setup-python/compare/v3...v4)

[Compare Source](https://github.com/actions/setup-python/compare/v3...v4)

</details>

<details>
<summary>googleapis/python-bigquery</summary>

### [`v3.3.1`](https://github.com/googleapis/python-bigquery/blob/HEAD/CHANGELOG.md#&#8203;331-httpsgithubcomgoogleapispython-bigquerycomparev330v331-2022-08-09)

##### Bug Fixes

-   **deps:** allow pyarrow < 10 ([#&#8203;1304](https://github.com/googleapis/python-bigquery/issues/1304)) ([13616a9](https://github.com/googleapis/python-bigquery/commit/13616a910ba2e9b7bc3595847229b56e70c99f84))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-dlp).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNTAuNCIsInVwZGF0ZWRJblZlciI6IjMyLjE1MC40In0=-->
parthea pushed a commit that referenced this pull request Oct 21, 2023
@renovate-bot
chore(deps): update dependency backoff to v2.0.1 (#419)
cdb6dad
parthea pushed a commit that referenced this pull request Oct 21, 2023
@release-please
chore(main): release 1.12.1 (#419)
0cd9e2c 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Oct 21, 2023
@lucianommartins @parthea
docs(samples): fixing file saving for local documents translation (#419)
665c674 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
feat: Add routing information in Cloud Build GRPC clients (#419)
c54eeef 
* feat: Add routing information in Cloud Build GRPC clients

PiperOrigin-RevId: 547283196

Source-Link: googleapis/googleapis@64d54ff

Source-Link: googleapis/googleapis-gen@1de1822
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMWRlMTgyMjExMDliNGEwMjVjMGIyZThjMjUzMjRjYjAxYjZkZjYyNiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix: Revert breaking change of main pattern

PiperOrigin-RevId: 547506413

Source-Link: googleapis/googleapis@8080bbe

Source-Link: googleapis/googleapis-gen@ac98388
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWM5ODM4OGJiODMyZGJlYmMwYmNkNmI3NDgwMDEwNTczYzBiYmRjNCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: core api: datastore Issues related to the Datastore API. api: storage Issues related to the Cloud Storage API. auth testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhermes @coveralls @tseaver @silvolu