Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #423: Expose the 'more_results' value fetched from the back-end. #425

Merged
merged 1 commit into from
Dec 17, 2014
Merged

Fix #423: Expose the 'more_results' value fetched from the back-end. #425

merged 1 commit into from
Dec 17, 2014

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Dec 17, 2014

Include notes that it is known to be currently un-useful, since the
back-end sets it to indicate there are more results willy-nilly.

Fixes #423.

@tseaver
Expose the 'more_results' value fetched from the back-end.
5743370 
Include notes that it is known to be currently un-useful, since the
back-end sets it to indicate there are more results willy-nilly.

Fixes #423.
dhermes
dhermes reviewed Dec 17, 2014
View reviewed changes
gcloud/datastore/query.py
# NOTE: `query_results` contains an extra value that we don't use,
# namely `skipped_results`.
#
# NOTE: The value of `more_results` is not currently useful because

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Dec 17, 2014

I was hoping to remove storing a cursor on Query in work on #336.

As I mentioned in #423, neither the returned cursor nor more_results belong on the Query object. This is even more true since we are allowing a query to be re-used after the fact.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 5743370 on tseaver:423-expose_query_more_results into cf2b306 on GoogleCloudPlatform:master.

@tseaver tseaver mentioned this pull request Dec 17, 2014
Closed
dhermes
dhermes reviewed Dec 17, 2014
View reviewed changes
gcloud/datastore/test_query.py
@@ -51,10 +51,12 @@ def test__clone(self):
_DATASET = 'DATASET'
_KIND = 'KIND'
_CURSOR = 'DEADBEEF'
_MORE_RESULTS = 2

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Dec 17, 2014

LGTM pending comments about tests tied to an enum val which may change. (Not really tied to it since no request over network, but kind of.)

Also, I think we should map the MoreResultsType into booleans, but I can handle that in the follow up which will tear more_results and cursor off the Query object (as discussed in #423).

tseaver added a commit that referenced this pull request Dec 17, 2014
@tseaver
Merge pull request #425 from tseaver/423-expose_query_more_results
1b9f1c2 
Fix #423:  Expose the 'more_results' value fetched from the back-end.
@tseaver tseaver merged commit 1b9f1c2 into googleapis:master Dec 17, 2014
@tseaver tseaver deleted the 423-expose_query_more_results branch December 17, 2014 19:36
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Dec 17, 2014
@dhermes
Removing cursor and more results from query object.
715f8d6 
This is a follow up to a discussion in googleapis#423 and googleapis#425.

Also
- Adding fetch_page() method to return the needed properties
  no longer available on the Query object.
- Made fetch_page() fail if more_results is `NOT_FINISHED`, which
  seems to be intended for batched requests.
- Added start_cursor and end_cursor properties to Query.
- Updated docstrings to reflect change
- Updated tests to ensure the returned cursor was always set.
- Streamlined fetch()/fetch_page() tests to run via a single
  tweakable helper.
- Updated a datastore.connection test to construct and return an
  initialized QueryResultBatch to simulate a valid cursor.
- Updated regression.clear_datastore and regression.datastore to
  reflect changed API surface.
@dhermes dhermes mentioned this pull request Dec 17, 2014
Merged
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Dec 17, 2014
@dhermes
Removing cursor and more results from query object.
2d40365 
This is a follow up to a discussion in googleapis#423 and googleapis#425.

Also
- Adding fetch_page() method to return the needed properties
  no longer available on the Query object.
- Made fetch_page() fail if more_results is `NOT_FINISHED`, which
  seems to be intended for batched requests.
- Added start_cursor and end_cursor properties to Query.
- Updated docstrings to reflect change
- Updated tests to ensure the returned cursor was always set.
- Streamlined fetch()/fetch_page() tests to run via a single
  tweakable helper.
- Updated a datastore.connection test to construct and return an
  initialized QueryResultBatch to simulate a valid cursor.
- Updated regression.clear_datastore and regression.datastore to
  reflect changed API surface.
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Dec 18, 2014
@dhermes
Removing cursor and more results from query object.
78d0dde 
This is a follow up to a discussion in googleapis#423 and googleapis#425.

Also
- Adding fetch_page() method to return the needed properties
  no longer available on the Query object.
- Made fetch_page() fail if more_results is `NOT_FINISHED`, which
  seems to be intended for batched requests.
- Added start_cursor and end_cursor properties to Query.
- Updated docstrings to reflect change
- Updated tests to ensure the returned cursor was always set.
- Streamlined fetch()/fetch_page() tests to run via a single
  tweakable helper.
- Updated a datastore.connection test to construct and return an
  initialized QueryResultBatch to simulate a valid cursor.
- Updated regression.clear_datastore and regression.datastore to
  reflect changed API surface.
@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015
atulep pushed a commit that referenced this pull request Apr 3, 2023
@parthea
fix(deps): allow protobuf < 5.0.0 (#425)
24dc2c1 
fix(deps): require proto-plus >= 1.22.0
atulep pushed a commit that referenced this pull request Apr 6, 2023
@parthea
fix(deps): allow protobuf < 5.0.0 (#425)
640bc44 
fix(deps): require proto-plus >= 1.22.0
atulep pushed a commit that referenced this pull request Apr 6, 2023
@parthea
fix(deps): allow protobuf < 5.0.0 (#425)
6ffda5e 
fix(deps): require proto-plus >= 1.22.0
atulep pushed a commit that referenced this pull request Apr 18, 2023
@parthea
fix(deps): allow protobuf < 5.0.0 (#425)
8aee295 
fix(deps): require proto-plus >= 1.22.0
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
chore(python): exclude setup.py in renovate config (#425)
be8c296 
Source-Link: googleapis/synthtool@56da63e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:993a058718e84a82fda04c3177e58f0a43281a996c7c395e0a56ccc4d6d210d7
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
docs: Update documentation for Security Command Center *.assets.list …
d3a7c68 
…"parent" parameter (#425)

* docs: Update documentation for Security Command Center *.assets.list "parent" parameter

PiperOrigin-RevId: 501630229

Source-Link: googleapis/googleapis@914dc31

Source-Link: googleapis/googleapis-gen@3bb94cc
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiM2JiOTRjY2E4NjI4Y2QzYzhlZjA5NGQ4NTFjZDcwYjQ1YTExOTMxOSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@galz10
docs(samples): Added comments (#425)
c0391f4 
* docs(samples): Added comments

* changed comment
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@release-please
chore: release 2.10.0 (#417)
eeb9397 
🤖 I have created a release \*beep\* \*boop\*
---
## [2.10.0](https://www.github.com/googleapis/python-dialogflow/compare/v2.9.1...v2.10.0) (2021-11-12)


### Features

* add context manager support in client ([#416](https://www.github.com/googleapis/python-dialogflow/issues/416)) ([317187c](https://www.github.com/googleapis/python-dialogflow/commit/317187cbaacc6889d6fff5d7ea483fe1bc2cd9ee))
* add document metadata filter in article suggestion ([#437](https://www.github.com/googleapis/python-dialogflow/issues/437)) ([56a6e11](https://www.github.com/googleapis/python-dialogflow/commit/56a6e11622f73c6d302a5f43142ceb289b334fd1))
* add smart reply model in human agent assistant ([56a6e11](https://www.github.com/googleapis/python-dialogflow/commit/56a6e11622f73c6d302a5f43142ceb289b334fd1))
* add support for python 3.10 ([#422](https://www.github.com/googleapis/python-dialogflow/issues/422)) ([652e2e8](https://www.github.com/googleapis/python-dialogflow/commit/652e2e8d860f369b62e7866d6cf220204740ade8))
* **v2:** added support to configure security settings, language code and time zone on conversation profile ([#431](https://www.github.com/googleapis/python-dialogflow/issues/431)) ([6296673](https://www.github.com/googleapis/python-dialogflow/commit/629667367d7098cfb62bae1b6e48cc11a72b9fbc))


### Bug Fixes

* **deps:** drop packaging dependency ([fd06e9f](https://www.github.com/googleapis/python-dialogflow/commit/fd06e9fe8626ac3d86175518c52ff14efebc0f7b))
* **deps:** require google-api-core >= 1.28.0 ([fd06e9f](https://www.github.com/googleapis/python-dialogflow/commit/fd06e9fe8626ac3d86175518c52ff14efebc0f7b))


### Documentation

* clarified meaning of the legacy editions ([#426](https://www.github.com/googleapis/python-dialogflow/issues/426)) ([d7a7544](https://www.github.com/googleapis/python-dialogflow/commit/d7a7544ce69cb357d7cad13e9a44afe26c6d3cf5))
* clarified semantic of the streaming APIs ([d7a7544](https://www.github.com/googleapis/python-dialogflow/commit/d7a7544ce69cb357d7cad13e9a44afe26c6d3cf5))
* list oneofs in docstring ([fd06e9f](https://www.github.com/googleapis/python-dialogflow/commit/fd06e9fe8626ac3d86175518c52ff14efebc0f7b))
* **samples:** Added comments ([#425](https://www.github.com/googleapis/python-dialogflow/issues/425)) ([f5d40dc](https://www.github.com/googleapis/python-dialogflow/commit/f5d40dc9b4bb57b8830dcd6541a2a1189a6c9780))
* **v2beta1:** clarified meaning of the legacy editions ([fd06e9f](https://www.github.com/googleapis/python-dialogflow/commit/fd06e9fe8626ac3d86175518c52ff14efebc0f7b))
* **v2beta1:** clarified semantic of the streaming APIs ([fd06e9f](https://www.github.com/googleapis/python-dialogflow/commit/fd06e9fe8626ac3d86175518c52ff14efebc0f7b))
* **v2beta1:** recommend AnalyzeContent for future users ([#420](https://www.github.com/googleapis/python-dialogflow/issues/420)) ([1afdab3](https://www.github.com/googleapis/python-dialogflow/commit/1afdab3b50c98cc082b150ff408d0f07f11f9cf3))
* **v2:** recommend AnalyzeContent for future users ([#421](https://www.github.com/googleapis/python-dialogflow/issues/421)) ([c6940a9](https://www.github.com/googleapis/python-dialogflow/commit/c6940a9f974af95037616bd1affb34d8db4405c9))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Sep 22, 2023
@renovate-bot
chore(deps): update dependency pytest to v7.2.1 (#425)
9e76fd5
parthea added a commit that referenced this pull request Sep 22, 2023
@release-please @parthea
chore(main): release 4.0.3 (#425)
54d1b69 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit that referenced this pull request Sep 22, 2023
@renovate-bot @parthea
chore(deps): update dependency google-cloud-videointelligence to v2.1…
1dca9c8 
…1.2 (#425)

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
feat: Add SavedQuery CURD support (#425)
788cc3f 
- [ ] Regenerate this pull request now.

feat: Add tags support
feat: Add RelatedAsset and deprecate RelatedAssets for relationship GA

*The previous representation of the relationship feature is deprecated and unimplemented. The RelatedAsset message represents the new stable format.

PiperOrigin-RevId: 449306805

Source-Link: googleapis/googleapis@3d7bd9d

Source-Link: googleapis/googleapis-gen@71a93d0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzFhOTNkMDVkNjA3NjI3MWQwNGI3NTkyZjdmYWQwZDNmMGM3YTA0MCJ9
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
build(deps): [autoapprove] bump pygments from 2.13.0 to 2.15.0 (#425)
50150fa 
Source-Link: https://github.com/googleapis/synthtool/commit/eaef28efd179e6eeb9f4e9bf697530d074a6f3b9
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f8ca7655fa8a449cadcabcbce4054f593dcbae7aeeab34aa3fcc8b5cf7a93c9e
parthea added a commit that referenced this pull request Oct 21, 2023
@parthea
fix(deps): allow protobuf < 5.0.0 (#425)
4997b42 
fix(deps): require proto-plus >= 1.22.0
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(python): exclude grpcio==1.49.0rc1 in tests [autoapprove] (#425)
51724a0 
Source-Link: googleapis/synthtool@c4dd595
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ce3c1686bc81145c81dd269bd12c4025c6b275b22d14641358827334fddb1d72
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
build(deps): [autoapprove] bump pygments from 2.13.0 to 2.15.0 (#425)
853e8ee 
Source-Link: https://github.com/googleapis/synthtool/commit/eaef28efd179e6eeb9f4e9bf697530d074a6f3b9
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f8ca7655fa8a449cadcabcbce4054f593dcbae7aeeab34aa3fcc8b5cf7a93c9e
parthea added a commit that referenced this pull request Oct 22, 2023
@parthea
fix(deps): allow protobuf < 5.0.0 (#425)
366bc0f 
fix(deps): require proto-plus >= 1.22.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: datastore Issues related to the Datastore API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query should expose the value of more_result after query.fetch is called
3 participants
@tseaver @dhermes @coveralls