Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spanner: Database not found #4557

Merged
merged 3 commits into from
Dec 20, 2017
Merged

Spanner: Database not found #4557

merged 3 commits into from
Dec 20, 2017

Commits on Dec 20, 2017

  1. Spanner: Fix database not found error, Closes googleapis#4071

    @chemelnucfin @dhermes
    chemelnucfin authored and dhermes committed Dec 20, 2017
    Configuration menu
    Copy the full SHA
    7c9b048 View commit details
    Browse the repository at this point in the history

  2. Final review pass. 

    Using `assertRaises` instead of a `self.fail()` branch that
will never get triggered.

Also moving around imports in `google.cloud.spanner_v1.database`
to be alphabetical / separated by 1st-party and 3rd-party.
    @dhermes
    dhermes committed Dec 20, 2017
    Configuration menu
    Copy the full SHA
    9c62777 View commit details
    Browse the repository at this point in the history

  3. Making sure newly created database gets dropped.

    @dhermes
    dhermes committed Dec 20, 2017
    Configuration menu
    Copy the full SHA
    98874c9 View commit details
    Browse the repository at this point in the history