-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not quote embedded slashes for public / signed URLs #4716
Merged
tseaver
merged 3 commits into
master
from
3809-storage-investigate-not-quoting-embedded-slash
Feb 26, 2018
Merged
Do not quote embedded slashes for public / signed URLs #4716
tseaver
merged 3 commits into
master
from
3809-storage-investigate-not-quoting-embedded-slash
Feb 26, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tseaver
added
api: datastore
Issues related to the Datastore API.
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
labels
Jan 8, 2018
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Jan 8, 2018
chemelnucfin
added
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
priority: p2
Moderately-important priority. Fix may not be included in next release.
labels
Jan 15, 2018
tseaver
removed
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
labels
Feb 20, 2018
Adding a system test to verify fetching hierarchical blobs directly: it fails without the quoting.
Leave it unquoted for 'public_url' and 'generate_signed_url'.
tseaver
force-pushed
the
3809-storage-investigate-not-quoting-embedded-slash
branch
from
February 22, 2018 22:46
93074c3
to
5437739
Compare
@tseaver, it looks like it's still failing. Did you update the PR given the last commit was back in Jan 8?
|
@tseaver, I think it's a unicode issue given the following SO question. Given that, the line could be updated with:
|
tseaver
changed the title
WIP: try not quoting the embedded slash in blob names.
Do not quote embedded slashes for public / signed URLs
Feb 26, 2018
Python 2.7's 'quote' requires bytes.
tseaver
added
api: storage
Issues related to the Cloud Storage API.
and removed
api: datastore
Issues related to the Datastore API.
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
labels
Feb 26, 2018
@frankyn Thanks for tracking that down! |
theacodes
approved these changes
Feb 26, 2018
tseaver
deleted the
3809-storage-investigate-not-quoting-embedded-slash
branch
February 26, 2018 20:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: storage
Issues related to the Cloud Storage API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3809.
As noted on that issue, the
public_url
andgenerate_signed_url
methods use the XML endpoints, which allow for / expect the slash not to be quoted. All other methods use the JSON endpoints, which require quoting the embedded slashes.