Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "api_core: Make PageIterator.item_to_value public. (#4702)" #4731

Merged
merged 2 commits into from
Jan 11, 2018

Conversation

theacodes
Copy link
Contributor

This reverts commit 813a27e.

This is done to prevent a release-the-world scenario in order to release bigquery, spanner, and datastore. It will be re-reverted before the next minor release of api_core.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 10, 2018
@dhermes
Copy link
Contributor

dhermes commented Jan 10, 2018

@jonparrott This is just a straight git revert. You also need to update spanner/google/cloud/spanner_v1/client.py and spanner/google/cloud/spanner_v1/instance.py:

$ git log -1 --pretty=%H
d2ff0b9a68b55dff09b905736df7ddaaf722ce95
$ git grep -l '\.item_to_value'
api_core/google/api_core/page_iterator.py
api_core/tests/unit/test_page_iterator.py
bigquery/tests/unit/test_table.py
datastore/google/cloud/datastore/query.py
spanner/google/cloud/spanner_v1/client.py
spanner/google/cloud/spanner_v1/instance.py

@theacodes
Copy link
Contributor Author

@dhermes good call.

@dhermes
Copy link
Contributor

dhermes commented Jan 10, 2018

LGTM

@theacodes theacodes merged commit b0dc7bc into master Jan 11, 2018
@theacodes theacodes deleted the revert-4702 branch January 11, 2018 00:54
theacodes pushed a commit that referenced this pull request Jan 11, 2018
dhermes pushed a commit that referenced this pull request Jan 12, 2018
theacodes pushed a commit that referenced this pull request Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants