Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid copying a limit to query protobuf unless explicitly passed. #492

Merged
merged 1 commit into from
Jan 6, 2015
Merged

Avoid copying a limit to query protobuf unless explicitly passed. #492

merged 1 commit into from
Jan 6, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jan 6, 2015

Fixes #491.

@dhermes
Copy link
Contributor

dhermes commented Jan 6, 2015

LGTM pending Travis

@dhermes
Copy link
Contributor

dhermes commented Jan 6, 2015

Feel free to merge

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling ec1bb14 on tseaver:491-fix_query_wo_limit into 22c8b19 on GoogleCloudPlatform:master.

tseaver added a commit that referenced this pull request Jan 6, 2015
Avoid copying a limit to query protobuf unless explicitly passed.
@tseaver tseaver merged commit 9b64977 into googleapis:master Jan 6, 2015
@tseaver tseaver deleted the 491-fix_query_wo_limit branch January 7, 2015 00:00
@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015
tswast added a commit to tswast/google-cloud-python that referenced this pull request Mar 26, 2019
* Add handwritten model API classes.

These classes provide the top-level classes for the Model API. The
protocol buffer objects are used for all sub-objects.

The pattern for mutable properties follows the same as with Table and
Dataset: a `_properties` dictionary contains the property values in the
REST API format.

* Address review comments in Model.

Use setdefault for labels.
Simplify setter logic for expires.

* Combine error messages for too many and too few parts in model/table ID.
atulep pushed a commit that referenced this pull request Apr 3, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 6, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 6, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 18, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Aug 15, 2023
* chore: fix proto formatting

PiperOrigin-RevId: 503230949

Source-Link: googleapis/googleapis@55dd4d7

Source-Link: googleapis/googleapis-gen@588ff38
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTg4ZmYzOGNmM2EyZGQyMjY0ZGE1YjAzMGQxZjcyZTU2YzdmZmM2NiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
parthea pushed a commit that referenced this pull request Sep 22, 2023
Source-Link: https://github.com/googleapis/synthtool/commit/5f2a6089f73abf06238fe4310f6a14d6f6d1eed3
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8555f0e37e6261408f792bfd6635102d2da5ad73f8f09bcb24f25e6afb5fac97
parthea pushed a commit that referenced this pull request Oct 21, 2023
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 472772457

Source-Link: googleapis/googleapis@855b74d

Source-Link: googleapis/googleapis-gen@b64b1e7
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjY0YjFlN2RhM2UxMzhmMTVjYTM2MTU1MmVmMDU0NWU1NDg5MWI0ZiJ9
parthea pushed a commit that referenced this pull request Oct 21, 2023
* chore: Update gapic-generator-python to v1.11.2

PiperOrigin-RevId: 546510849

Source-Link: googleapis/googleapis@736073a

Source-Link: googleapis/googleapis-gen@deb64e8
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGViNjRlOGVjMTlkMTQxZTMxMDg5ZmU5MzJiM2E5OTdhZDU0MWM0ZCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 22, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the Datastore API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query.fetch() w/o limit returns different results than w/ large limit.
3 participants