BigQuery: address dataset leaks #6099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tseaver
force-pushed
the
6098-bigquery-dataset_leaks
branch
from
94b050e
to
ed76f14
Compare
tswast
reviewed
Sep 25, 2018
There was a problem hiding this comment.
I'd actually recommend doing something similar to googleapis/python-bigquery-pandas#216 where I use a pytest fixture to cleanup any leftover datasets without having to list all of them (which is quite flaky in BigQuery, unfortunately).
| pattern = re.compile( | ||
| '|'.join('^{}.*$'.format(prefix) for prefix in prefixes)) | ||
|
|
||
| ds_items = list(client.list_datasets()) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tswast
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toward #6098.
Closes #6097.