Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery: fix swallowed error message #6168

Merged
merged 2 commits into from
Oct 10, 2018

Commits on Oct 4, 2018

  1. [bigquery] fix swallowed error message

    When getting a "Cannot query over table (...) without a filter over
    column(s) (...)", the re-raising happening gobbles up the error message
    and the context is lost.
    
    This may or may not be the right fix, but clearly highlights the issue
    of `self._query_job.errors` being `None` in that particular context.
    When that is the case, the only context available is that of
    `DatabaseError` without any details which clearly isn't enough detail.
    
    It seems like wrapping the exception into another exception works as
    expected and shows both stack traces as shown here:
    mistercrunch committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    a0fda13 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2018

  1. Pass just the exception to DatabaseError

    The errors on the job resource are mostly redundant with the exception information.
    tswast committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    d52c87f View commit details
    Browse the repository at this point in the history