Add methods to api_core used by new autogenerator. #6267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 18, 2018 10:45
This adds convenience methods used by client libraries produced by gapic-generator-python.
googlebot
added
the
cla: yes
lukesneeringer
changed the title
theacodes
suggested changes
Oct 18, 2018
api_core/setup.py
Outdated
| @@ -22,12 +22,12 @@ | |||
|
|
|||
| name = 'google-api-core' | |||
| description = 'Google API client core library' | |||
| version = '1.5.0' | |||
| version = '1.6.0a1' | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
added 2 commits
October 18, 2018 11:19
lukesneeringer
force-pushed
the
core-1.6.0
branch
from
fab68f9 to
fdee800
Compare
tseaver
suggested changes
Oct 18, 2018
api_core/setup.py
Outdated
| @@ -27,7 +27,7 @@ | |||
| # 'Development Status :: 3 - Alpha' | |||
| # 'Development Status :: 4 - Beta' | |||
| # 'Development Status :: 5 - Production/Stable' | |||
| release_status = 'Development Status :: 5 - Production/Stable' | |||
| release_status = 'Development Status :: 3 - Alpha' | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Let's still revert the chAnge here.
…On Thu, Oct 18, 2018, 12:27 PM Luke Sneeringer ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In api_core/setup.py
<#6267 (comment)>
:
> @@ -27,7 +27,7 @@
# 'Development Status :: 3 - Alpha'
# 'Development Status :: 4 - Beta'
# 'Development Status :: 5 - Production/Stable'
-release_status = 'Development Status :: 5 - Production/Stable'
+release_status = 'Development Status :: 3 - Alpha'
Goal is to release a 1.6.0a1 and *not* ship this by default to everyone
just yet.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#6267 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPUcwqbYltIbJK3oG38fhW7mVDZ4pR1ks5umNY6gaJpZM4XuCLU>
.
|
|
Fair enough! Done. |
tseaver
approved these changes
Oct 18, 2018
|
Distilling a Hangouts discussion: We are moving the dispatch item to a |
crwilcox
approved these changes
Oct 18, 2018
tseaver
added a commit
that referenced
this pull request
Oct 29, 2018
We will bring them back in when we have an OK to make a non-alpha 'api_core-1.6.0' release. Toward #6326.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two methods to
google-api-corethat will be used by the new GAPICs.It also bumps the version number to
1.6.0a1, so that we can release this to PyPI and iterate without affecting existing users.