Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage: accomodate new back-end restriction on retention period. #6388

Merged
merged 2 commits into from
Nov 5, 2018
Merged

Storage: accomodate new back-end restriction on retention period. #6388

merged 2 commits into from
Nov 5, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Nov 5, 2018

Closes #6368.

@tseaver tseaver added the api: storage Issues related to the Cloud Storage API. label Nov 5, 2018
@tseaver tseaver requested a review from frankyn November 5, 2018 16:50
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 5, 2018
frankyn
frankyn reviewed Nov 5, 2018
View reviewed changes
Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM. I'll approve after pending tests are complete.

@tseaver
Copy link
Contributor Author

tseaver commented Nov 5, 2018

@frankyn The pubsub failure is a Kokoro docker /networking barf (as well as being obviously unrelated to this PR).

frankyn
frankyn approved these changes Nov 5, 2018
View reviewed changes
Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tseaver!

@tseaver tseaver merged commit 062235c into googleapis:master Nov 5, 2018
@tseaver tseaver deleted the 6368-storage-bucket_retention_property_setter_none branch November 5, 2018 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankyn frankyn frankyn approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @frankyn @googlebot