Replacing _implicit_environ module globals with a container. #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dhermes
force-pushed
the
use-implicit-defaults-container
branch
from
168d94a
to
5a7071d
Compare
dhermes
force-pushed
the
use-implicit-defaults-container
branch
from
5a7071d
to
5a91e30
Compare
|
@tseaver Rebased |
Closed
| @@ -141,8 +147,10 @@ def test_set_gcd_and_production_env_vars(self): | |||
| with self._monkeyImplicit(): | |||
| self._callFUT() | |||
|
|
|||
| self.assertNotEqual(_implicit_environ.DATASET_ID, GCD_DATASET_ID) | |||
| self.assertEqual(_implicit_environ.DATASET_ID, IMPLICIT_DATASET_ID) | |||
| self.assertNotEqual(_implicit_environ.get_default_dataset_id(), | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Except for the two redundant assertions I noted, LGTM. |
This is so that a container instance can have lazily loaded properties.
dhermes
force-pushed
the
use-implicit-defaults-container
branch
from
5a91e30
to
b0cdca6
Compare
|
Rebased and folded the removal into the original commit. Will merge on Travis. |
dhermes
added a commit
that referenced
this pull request
Feb 19, 2015
Replacing _implicit_environ module globals with a container.
vchudnov-g
pushed a commit
that referenced
this pull request
Sep 20, 2023
* docs: Minor formatting PiperOrigin-RevId: 553461544 Source-Link: googleapis/googleapis@347e81d Source-Link: googleapis/googleapis-gen@1177b66 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTE3N2I2NjNkZTUwMDc5ZGJjZmNiYjdlZWJlOTljN2VlMjFjYTA3NCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so that a container instance can have lazily loaded properties.
NOTE: Has #663 as a diffbase