Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unwinding cases in Test_set_default_dataset_id and having better test separation #672

Merged
merged 5 commits into from
Feb 26, 2015
Merged

Unwinding cases in Test_set_default_dataset_id and having better test separation #672

merged 5 commits into from
Feb 26, 2015

Commits on Feb 25, 2015

  1. Adding _determine_default_dataset_id test to assert call order. 

    Also defining one-liner _get_production_dataset_id() and
_get_gcd_dataset_id() methods to mirror the app_engine_id()
and compute_engine_id() methods in _implicit_environ.
    @dhermes
    dhermes committed Feb 25, 2015
    Configuration menu
    Copy the full SHA
    428f247 View commit details
    Browse the repository at this point in the history

  2. Adding tests for _get_(production|gcd)_dataset_id().

    @dhermes
    dhermes committed Feb 25, 2015
    Configuration menu
    Copy the full SHA
    d37846e View commit details
    Browse the repository at this point in the history

  3. Testing app_engine_id() in _implicit_environ.

    @dhermes
    dhermes committed Feb 25, 2015
    Configuration menu
    Copy the full SHA
    0ceeaef View commit details
    Browse the repository at this point in the history

  4. Testing compute_engine_id() in _implicit_environ. 

    Also fixing unused dataset_id=None in _callFUT in
Test__get_gcd_dataset_id and Test__get_gcd_dataset_id.
    @dhermes
    dhermes committed Feb 25, 2015
    Configuration menu
    Copy the full SHA
    12e39db View commit details
    Browse the repository at this point in the history

  5. Removing most of Test_set_default_dataset_id. 

    Also adding the relative ordering parts to Test__determine_default_dataset_id.

Tests previously were mixing the logic of the 4 possible environments
while the simple ordering of them in set_default_dataset_id() and
now _determine_default_dataset_id().

This separates that logic and makes sure each environ helper is called
in a specific order.
    @dhermes
    dhermes committed Feb 25, 2015
    Configuration menu
    Copy the full SHA
    1dd6709 View commit details
    Browse the repository at this point in the history