Fix py2->3 string issues

[foozlevazquez]

• Handle exceptions with binary string content. Added test.
• Handle api_requests with binary content correctly in Python 3. Added test.

[foozlevazquez]

See #671 for the full gory history.

[coveralls]

Coverage decreased (-0.02%) to 99.98% when pulling 9066b7e on foozlevazquez:dev-fix-py3-str-issues into 56f60bb on GoogleCloudPlatform:master.

[foozlevazquez]

@dhermes Can you help me understand why this is claiming no coverage, when it is being tested by these tests with and without binary strings? I'm hoping understanding that one will help me understand the other coverage failure. Thanks.

[dhermes]

From https://travis-ci.org/GoogleCloudPlatform/gcloud-python/builds/51608518#L383

gcloud.datastore.transaction                 32      0      4      0   100%   
gcloud.exceptions                            78      1     14      1    98%   175
gcloud.storage                               38      0     12      0   100%   
gcloud.storage._helpers                      60      0     12      0   100%   
gcloud.storage._implicit_environ              5      0      0      0   100%   
gcloud.storage.acl                          152      0     38      0   100%   
gcloud.storage.blob                         153      0     28      0   100%   
gcloud.storage.bucket                       180      0     48      0   100%   
gcloud.storage.connection                    68      1     18      1    98%   239

It looks like you've got 2 branch misses.

---

The line numbers are given, so hopefully they are easy to find. Typically a branch miss like this means in code like

if foo == bar:
    baz()

foo is always equal to bar. So you need to add a test for the "other" branch where foo != bar.

---

You can see this report by running tox -e cover locally. Sometimes a branch miss doesn't get the line reported, and in this case I generate the HTML report

coverage html
ls htmlcov/

[dhermes]

It's unclear which of these fixes were needed.

There are only two uses of http.request in our code:

$ git log -1 --pretty=%H  # Current HEAD
56f60bb94b313c397f5aeadee1f0e1f6e5b5290c
$ git grep -n 'http\.request' | egrep -v test | egrep -v -e '^_gcloud_vendor'
gcloud/datastore/connection.py:80:        headers, content = self.http.request(
gcloud/storage/connection.py:169:        return self.http.request(uri=url, method=method, headers=headers,

The auth issue should be fixed upstream in oauth2client.

The only change here is one in storage.Connection but it doesn't seem to address the headers.

WDYT? How did you determine these fixes were needed? (FWIW the isinstance(content, six.string_types) is needed.)

[dhermes]

I'm closing this out since it's being fixed upstream in httplib2 and oauth2client:
googleapis/oauth2client#104
googleapis/oauth2client#136
jcgregorio/httplib2#291
jcgregorio/httplib2#296