Adding back storage.lookup_bucket. #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was originally removed in googleapis#588.
googlebot
added
the
cla: yes
|
Changes Unknown when pulling f50d036 on dhermes:add-back-storage-bucket-lookup into * on GoogleCloudPlatform:master*. |
|
Moving the bucket-related functions to |
|
I'm not sure what the motivation is for re-adding the |
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Mar 12, 2015
See comments in googleapis#700 for context.
|
facepalm I should have gone back to look at #588. LGTM. |
dhermes
added a commit
that referenced
this pull request
Mar 12, 2015
Adding back storage.lookup_bucket.
|
Cool. I'll rebase #716 now. |
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Mar 12, 2015
See comments in googleapis#700 for context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally removed in #588.
@tseaver I'd like to remove all the bucket functions from
Connectionand move them intoapi. WDYT?Also it seems we'd eventually want to add a
_require_connectionas indatastore.api. It would be nice to come with a re-factor for re-usability (theBatchis the part which needs to be package specific).FWIW: I came across this while trying to make implicit auth work in storage. Importing
Connectionin_implicit_environcreates a cycle, essentially becauseConnectionimportsBucket.