Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensuring response from httplib2 is treated as str in Python 2 and bytes in Python3 #724

Closed
wants to merge 7 commits into from
Closed

Ensuring response from httplib2 is treated as str in Python 2 and bytes in Python3 #724

wants to merge 7 commits into from

Commits on Mar 16, 2015

  1. Ensuring content returned by httplib2 in gcloud.storage.connection.Co… 

    …nnection.api_request is decoded to a string before being passed to json.loads
    @craigloftus
    craigloftus committed Mar 16, 2015
    Configuration menu
    Copy the full SHA
    bc78d84 View commit details
    Browse the repository at this point in the history

  2. Changing responses from Http mock in gcloud.storage.test_connection t… 

    …o use six.binary_type
    @craigloftus
    craigloftus committed Mar 16, 2015
    Configuration menu
    Copy the full SHA
    d886eca View commit details
    Browse the repository at this point in the history

  3. Make exceptions work in Python 2 and 3

    @craigloftus
    craigloftus committed Mar 16, 2015
    Configuration menu
    Copy the full SHA
    1720e80 View commit details
    Browse the repository at this point in the history

  4. Refactoring make_exception to remove unused code and try to make the … 

    …intention clearer
    @craigloftus
    craigloftus committed Mar 16, 2015
    Configuration menu
    Copy the full SHA
    1d6c29c View commit details
    Browse the repository at this point in the history

  5. Making use of encode use utf-8 explicitly

    @craigloftus
    craigloftus committed Mar 16, 2015
    Configuration menu
    Copy the full SHA
    62e13d7 View commit details
    Browse the repository at this point in the history

  6. Fixing new tests and linting issue

    @craigloftus
    craigloftus committed Mar 16, 2015
    Configuration menu
    Copy the full SHA
    68fa37f View commit details
    Browse the repository at this point in the history

  7. Adding explicit check for binary_type in gcloud.storage.connection.ap… 

    …i_request
    @craigloftus
    craigloftus committed Mar 16, 2015
    Configuration menu
    Copy the full SHA
    4785d98 View commit details
    Browse the repository at this point in the history