Flesh out pubsub subscriptions #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This was referenced Mar 18, 2015
Merged
|
Holding off here is fine. |
Include 'create', 'delete', 'exists', and 'reload' method to manage subscription state. Allow toggling between push / pull w/ 'modify_push_config'. Consume / acknowledge messages in pull-mode w/ 'pull', 'acknowledge', and 'modify_ack_deadline'.
| def list_subscriptions(page_size=None, page_token=None, topic_name=None, | ||
| project=None, connection=None): | ||
| """List subscriptions for a given project. | ||
|
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM though you should get sign off from @tmatsuo to make sure you are making the correct API calls |
| params['pageToken'] = page_token | ||
|
|
||
| if topic_name is None: | ||
| path = '/projects/%s/subscriptions' % project |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Left few comments, but LGTM in terms of the correctness of API paths and methods. |
Addresses: #743 (comment).
| data=data) | ||
|
|
||
| def modify_ack_deadline(self, ack_id, ack_deadline): | ||
| """API call: update acknowledgement deadline for a retrieved messages. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
still LGTM |
[ci skip]
tseaver
added a commit
that referenced
this pull request
Mar 19, 2015
Flesh out pubsub subscriptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses #742 as a base.