Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#741: hoist project detection/setup into 'gcloud._helpers'. #748

Merged
merged 1 commit into from
Mar 23, 2015
Merged

#741: hoist project detection/setup into 'gcloud._helpers'. #748

merged 1 commit into from
Mar 23, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Mar 20, 2015

Second bullet for #741.

@tseaver tseaver added api: storage Issues related to the Cloud Storage API. api: core labels Mar 20, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 20, 2015
@tseaver tseaver mentioned this pull request Mar 20, 2015
Closed
@tseaver tseaver changed the title Hoist project detection/setup into 'gcloud._helpers'. #741: hoist project detection/setup into 'gcloud._helpers'. Mar 20, 2015
dhermes
dhermes reviewed Mar 20, 2015
View reviewed changes
gcloud/storage/__init__.py
@@ -41,11 +41,11 @@
import os

from gcloud import credentials
from gcloud._helpers import get_default_project

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Mar 20, 2015

So everything looks good but I want to resolve this discussion. Also still waiting on Travis.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling c590c56 on tseaver:741-hoist_default_project into * on GoogleCloudPlatform:master*.

@tseaver tseaver mentioned this pull request Mar 20, 2015
Merged
@tseaver
Copy link
Contributor Author

tseaver commented Mar 23, 2015

Per today's standup, @jgeewax believes that having the same default project across storage and pubsub (and maybe other APIs) is fine. Users who need to vary from the default just pass it explicitly.

tseaver added a commit that referenced this pull request Mar 23, 2015
@tseaver
Merge pull request #748 from tseaver/741-hoist_default_project
4512eff 
#741: hoist project detection/setup into 'gcloud._helpers'.
@tseaver tseaver merged commit 4512eff into googleapis:master Mar 23, 2015
@dhermes
Copy link
Contributor

dhermes commented Mar 23, 2015

@tseaver Can you rebase #749? I'm about to step out and want to finish the review.

@tseaver tseaver deleted the 741-hoist_default_project branch March 23, 2015 19:22
@dhermes dhermes mentioned this pull request Apr 9, 2015
Merged
@dhermes dhermes mentioned this pull request Apr 17, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: core api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @dhermes @coveralls @googlebot