Add Snippets for security center list_assets call #7538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crwilcox
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
tseaver
added
testing
type: docs
crwilcox
suggested changes
Mar 26, 2019
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 |
There was a problem hiding this comment.
This seems to be the old license header. Year should likely be 2019 and apache url should be be https.
#
# Copyright 2019 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
| # list_assets returns an iterator. We convert it to a list | ||
| # here for demonstration purposes only. Processing each element | ||
| # from the iterator is recommended. | ||
| assets = list( |
There was a problem hiding this comment.
Personally I would prefer not doing a thing in a sample we wouldn't recommend. Is there a motivation to convert this to a list in the sample?
There was a problem hiding this comment.
Mostly so I can asset on size. I changed this to use enumerate and print each index and result. Please let me know if there is something more idiomatic.
crwilcox
approved these changes
Mar 26, 2019
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
* Add Snippets for security center list_assets call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests starts adding snippets for Cloud Security Command Center (in particular the list_assets call). I tried to follow the contributing guide but apologize if I missed something.