Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery: Close the to_dataframe progress bar when finished. #7757

Merged
merged 1 commit into from
Apr 22, 2019
Merged

BigQuery: Close the to_dataframe progress bar when finished. #7757

merged 1 commit into from
Apr 22, 2019

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Apr 19, 2019

Otherwise it stays blue (incomplete) in the tqdm_notebook version. Not sure that it makes a difference in plain tqdm.

@tswast tswast requested a review from crwilcox as a code owner April 19, 2019 18:43
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 19, 2019
@tswast tswast changed the title Close the to_dataframe progress bar when finished. BigQuery: Close the to_dataframe progress bar when finished. Apr 19, 2019
@tswast tswast added the api: bigquery Issues related to the BigQuery API. label Apr 19, 2019
@tswast tswast requested review from shollyman and plamut April 19, 2019 18:43
@tswast tswast merged commit 3e06961 into googleapis:master Apr 22, 2019
@tswast tswast deleted the bq-progress-bar branch April 22, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

@plamut plamut Awaiting requested review from plamut

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tswast @shollyman @googlebot