Bigtable: add 'client_info' support to client. #7876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forward when constructing GAPIC API client objects.
googlebot
added
the
cla: yes
14 tasks
tswast
reviewed
May 8, 2019
| credentials=None, | ||
| read_only=False, | ||
| admin=False, | ||
| client_info=_CLIENT_INFO, |
There was a problem hiding this comment.
Since _CLIENT_INFO is mutable, should we be defaulting to None and making a copy of _CLIENT_INFO if not set? I guess we don't expect anyone to be mutating it, since _CLIENT_INFO and self._client_info are both private?
| client_class = mock.Mock() | ||
| credentials = _make_credentials() | ||
| client = _Client(credentials) | ||
| client_info = client._client_info = mock.Mock() |
| client_class = mock.Mock() | ||
| emulator_host = emulator_channel = object() | ||
| credentials = _make_credentials() | ||
| client = _Client( | ||
| credentials, emulator_host=emulator_host, emulator_channel=emulator_channel | ||
| ) | ||
| client_info = client._client_info = mock.Mock() |
There was a problem hiding this comment.
Ditto. We can use mock.create_autospec with instance=True to make doubly sure we don't use any properties on ClientInfo that don't exist.
| @@ -100,6 +102,13 @@ class Client(ClientWithProject): | |||
| interact with the Instance Admin or Table Admin APIs. This | |||
| requires the :const:`ADMIN_SCOPE`. Defaults to :data:`False`. | |||
|
|
|||
| :type: client_info: :class:`google.api_core.client_info.ClientInfo` | |||
There was a problem hiding this comment.
Does this need to be the google.api_core.gapic_v1.client_info.ClientInfo version, instead?
What happens when a google.api_core.client_info.ClientInfo is used? I imagine it might fail to populate the x-goog-api-client header?
This was referenced May 8, 2019
tswast
approved these changes
May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward when constructing GAPIC API client objects.
Toward #7825.